cli_common: reconnect on pulse errors#1968
Conversation
|
😄 i like the draft feature in github |
|
@La0 @garbas what do you think about this approach? It doesn't reconnect, but at least it detects the issue and should exit, letting either heroku or kubernetes to restart the container. We can probably wrap the function somehow so we reconnect, but I failed to do that properly for now. I may try and pursue this at some point. |
|
In eeac03f I added some reconnect logic. it should work (TM), but I'm not sure what would be the best way to test it... |
|
You could test it with Thanks for this patch, it will be used on pulselistener a lot 👍 |
|
I actually have a real local rabbitmq server that I can use, was wondering which service I should try to emulate :) |
|
Let's try something that I know, shipit worker |
|
It worked fine locally.
I think this should just work. We should probably watch the consumers after this merged to production. |
closes #827