This repository was archived by the owner on Nov 11, 2019. It is now read-only.
staticanalysis/bot: Coverity check for extra flags to be sure that we consume only local issues.#1884
Merged
Conversation
La0
reviewed
Feb 14, 2019
abpostelnicu
force-pushed
the
cov-only-local
branch
from
1e9f824 to
2624360
Compare
La0
reviewed
Feb 14, 2019
… consume only local issues.
abpostelnicu
force-pushed
the
cov-only-local
branch
from
2624360 to
9935b6b
Compare
marco-c
reviewed
Feb 14, 2019
| # According to Coverity manual: | ||
| # presentInReferenceSnapshot - True if the issue is present in the reference | ||
| # snapshot specified in the cov-run-desktop command, false if not. | ||
| return stateOnServer is not None and 'presentInReferenceSnapshot' in stateOnServer \ |
Collaborator
There was a problem hiding this comment.
Can stateOnServer be None? If it can't, then maybe we should assert.
Same with 'presentInReferenceSnapshot' in stateOnServer, if it is supposed to be always there, we should assert it is.
marco-c
approved these changes
Feb 14, 2019
abpostelnicu
added a commit
that referenced
this pull request
Feb 14, 2019
… consume only local issues. (#1884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.