Update dependencies (and a bit more)#1730
Conversation
|
Wow, this is a huge update! 🥇 |
| # | ||
| # COMMAND: | ||
| # pypi2nix -v -V 3.6 -r requirements.txt -r requirements-dev.txt | ||
| # pypi2nix -v -C /home/rok/dev/mozilla/services/lib/please_cli/../../tmp/pypi2nix -V 3.7 -O ../../nix/requirements_override.nix -e pytest-runner -e setuptools-scm -r requirements.txt -r requirements-dev.txt |
There was a problem hiding this comment.
Now I know where you save your files! :)
There was a problem hiding this comment.
😄 I need to fix this upstream to not leak this information
La0
left a comment
La0
left a comment
There was a problem hiding this comment.
Looks ok on staging.
I tested static analysis (bot & frontend), pulse listener, uplift (bot & backend), and code coverage bot.
| https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.0.0/en_core_web_sm-2.0.0.tar.gz#egg=en-core-web-sm | ||
| idna<2.8,>=2.5 # Could not find a version that satisfies the requirement idna<2.8,>=2.5 (from requests==2.20.1) | ||
| msgpack<0.6.0,>=0.5.6 # Could not find a version that satisfies the requirement msgpack<0.6.0,>=0.5.6 (from thinc==6.12.1) | ||
| pyOpenSSL>=0.14 # Could not find a version that satisfies the requirement pyOpenSSL>=0.14; extra == "security" (from requests[security]>=2.7.0->libmozdata==0.1.43) |
There was a problem hiding this comment.
It's a pity that we have to specify these requirements directly :(
There was a problem hiding this comment.
@marco-c yeah it is a pity.
but at least we catch this errors with nix. otherwise we would be blindly believe what pip gives us is correct and is far from the truth. the broken part of this process is pip and since it is silent about it nobody complains.
There was a problem hiding this comment.
Yeah we should try to fix them upstream, but it would take some time...
There was a problem hiding this comment.
the problem is not how dependencies are defined upstream. the problem here is pip resolver and how it handles requirements.txt
4 participants
Along with updating dependencies I'm also addressing few other issues which will take full rebuild: