This repository was archived by the owner on Nov 11, 2019. It is now read-only.
staticanalysis/bot: Do not publish patches without matching issues.#1708
Merged
Conversation
marco-c
reviewed
Nov 26, 2018
| analyzers_available = set(i.ANALYZER for i in issues).intersection(self.analyzers) | ||
| patches = { | ||
| analyzer: url | ||
| for analyzer, url in revision.improvement_patches.items() |
Collaborator
There was a problem hiding this comment.
Maybe we should filter out not allowed paths when we build revision.improvement_patches?
Contributor
Author
There was a problem hiding this comment.
That would mean parsing the chunks of the full clang-format patch itself, hence doing #1696
marco-c
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid this edge case where a patch with clang-format issues not publishable (due to paths not covered) is published even though the linked issues are silent
Fixes #1704