Skip to content

Improve preferences building, and generate the preferences_schema.json file for the Chromium addon#20603

Merged
Snuffleupagus merged 5 commits intomozilla:masterfrom
Snuffleupagus:createChromiumPrefsSchema
Jan 30, 2026
Merged

Improve preferences building, and generate the preferences_schema.json file for the Chromium addon#20603
Snuffleupagus merged 5 commits intomozilla:masterfrom
Snuffleupagus:createChromiumPrefsSchema

Conversation

@Snuffleupagus
Copy link
Collaborator

This avoids the hassle of having to manually update that file when adding/modifying preferences in the viewer.
Updating the preferences-metadata should now only be something that the Chromium addon maintainer has to do.

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0ddb7883bcc9010/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/74448fcc3db800c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0ddb7883bcc9010/output.txt

Total script time: 2.62 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/74448fcc3db800c/output.txt

Total script time: 8.82 mins

  • Unit Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a973a1c90de7e58/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a973a1c90de7e58/output.txt

Total script time: 21.72 mins

  • Integration Tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

…during building

This avoids the hassle of having to manually update that file when adding/modifying preferences in the viewer.
Updating the preferences-metadata should now only be something that the Chromium addon maintainer has to do.
This is a left-over from before the introduction of `AppOptions`, but is no longer necessary now.
…ly for all relevant build-targets

Given that previous patches reduced that number of build-targets running this code, ensure that it's still tested sufficiently.
This really isn't necessary, and it's just a left-over from before the code was moved into the current file.

Also, spotted during rebasing, use the existing "locale" hash-parameter in integration-tests rather than adding a duplicate one for testing.
@Snuffleupagus Snuffleupagus force-pushed the createChromiumPrefsSchema branch from 5f04a09 to 1370950 Compare January 30, 2026 13:07
@Snuffleupagus Snuffleupagus merged commit 814df09 into mozilla:master Jan 30, 2026
11 checks passed
@Snuffleupagus Snuffleupagus removed the request for review from timvandermeij January 30, 2026 13:12
@Snuffleupagus Snuffleupagus deleted the createChromiumPrefsSchema branch January 30, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants