Update image pattern in gulpfile to accommodate missing images#20554
Update image pattern in gulpfile to accommodate missing images#20554timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me, with the comment addressed and the commits squashed into one (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits).
|
Please fix the linting and squash the commits into one, with a good commit message (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits if you're not familiar with how to do that). It looks like after that this should be good to merge. |
dgiessing
force-pushed
the
patch-1
branch
2 times, most recently
from
8bf19c5 to
d072be1
Compare
|
@timvandermeij Should be good to go now. It shows changes of another file because I merged the master into the patch? |
|
You can update your master branch and then rebase your branch. |
Thank you for bearing with me should be good to go now! |
|
Thank you for your contribution! |
3 participants
Closes #20553