Skip to content

Avoid pattern creation with some basic gradients#20525

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:simplify_gradient
Dec 23, 2025
Merged

Avoid pattern creation with some basic gradients#20525
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:simplify_gradient

Conversation

@calixteman
Copy link
Contributor

Some gradients are represented as patterns in PDF.js, because they mustn't be affected by the current transform. But in most of the cases, the gradient is attached to the origin and the current transform is very basic (dilatation + orthogonal + translation). In those cases, we can avoid creating the pattern because the gradient is transformed into another gradient when the inverse transform is applied.

Some gradients are represented as patterns in PDF.js, because they
mustn't be affected by the current transform. But in most of the cases,
the gradient is attached to the origin and the current transform is very
basic (dilatation + orthogonal + translation). In those cases, we can
avoid creating the pattern because the gradient is transformed into
another gradient when the inverse transform is applied.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ae728adbff06b23/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/5dc06080127391b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ae728adbff06b23/output.txt

Total script time: 40.83 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 12

Image differences available at: http://54.241.84.105:8877/ae728adbff06b23/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/5dc06080127391b/output.txt

Total script time: 76.93 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 12

Image differences available at: http://54.193.163.58:8877/5dc06080127391b/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thank you for improving this!

@timvandermeij timvandermeij merged commit dd6459c into mozilla:master Dec 23, 2025
10 checks passed
@timvandermeij
Copy link
Contributor

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9f2ede11b85effb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9745d0bad6b933c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9f2ede11b85effb/output.txt

Total script time: 18.78 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/9745d0bad6b933c/output.txt

Total script time: 31.98 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants