Aria-hide the text content part of a MathML formula (bug 1998046)#20471
Merged
calixteman merged 1 commit intomozilla:masterfrom Dec 4, 2025
Merged
Aria-hide the text content part of a MathML formula (bug 1998046)#20471calixteman merged 1 commit intomozilla:masterfrom
calixteman merged 1 commit intomozilla:masterfrom
Conversation
It'll avoid to have the text content and the MathML content read by screen readers.
timvandermeij
approved these changes
Dec 4, 2025
Contributor
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing integration tests. Looks good!
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/80d0b4e476a3a1d/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a9f44a18f0e72d2/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/80d0b4e476a3a1d/output.txt Total script time: 21.36 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a9f44a18f0e72d2/output.txt Total script time: 41.54 mins
|
calixteman
added a commit
to calixteman/pdf.js
that referenced
this pull request
Jan 12, 2026
…2009627) The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf. When those annotations are added to the DOM, the struct tree has to be rendered but without the text layer (because of asynchronicity). So this patch is making sure that the modifications in the text layer are done once the layer is rendered.
calixteman
added a commit
to calixteman/pdf.js
that referenced
this pull request
Jan 13, 2026
…2009627) The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf. When those annotations are added to the DOM, the struct tree has to be rendered but without the text layer (because of asynchronicity). So this patch is making sure that the modifications in the text layer are done once the layer is rendered.
calixteman
added a commit
to calixteman/pdf.js
that referenced
this pull request
Jan 13, 2026
…2009627) The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf. When those annotations are added to the DOM, the struct tree has to be rendered but without the text layer (because of asynchronicity). So this patch is making sure that the modifications in the text layer are done once the layer is rendered.
calixteman
added a commit
to calixteman/pdf.js
that referenced
this pull request
Jan 13, 2026
…2009627) The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf. When those annotations are added to the DOM, the struct tree has to be rendered but without the text layer (because of asynchronicity). So this patch is making sure that the modifications in the text layer are done once the layer is rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'll avoid to have the text content and the MathML content read by screen readers.