Skip to content

Aria-hide the text content part of a MathML formula (bug 1998046)#20471

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:bug1998046_1
Dec 4, 2025
Merged

Aria-hide the text content part of a MathML formula (bug 1998046)#20471
calixteman merged 1 commit intomozilla:masterfrom
calixteman:bug1998046_1

Conversation

@calixteman
Copy link
Contributor

It'll avoid to have the text content and the MathML content read by screen readers.

It'll avoid to have the text content and the MathML content read by
screen readers.
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing integration tests. Looks good!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/80d0b4e476a3a1d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a9f44a18f0e72d2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/80d0b4e476a3a1d/output.txt

Total script time: 21.36 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a9f44a18f0e72d2/output.txt

Total script time: 41.54 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 8435e8f into mozilla:master Dec 4, 2025
7 checks passed
@calixteman calixteman deleted the bug1998046_1 branch December 4, 2025 21:10
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 12, 2026
…2009627)

The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf.
When those annotations are added to the DOM, the struct tree has to be rendered but without
the text layer (because of asynchronicity).
So this patch is making sure that the modifications in the text layer are done once the
layer is rendered.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 13, 2026
…2009627)

The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf.
When those annotations are added to the DOM, the struct tree has to be rendered but without
the text layer (because of asynchronicity).
So this patch is making sure that the modifications in the text layer are done once the
layer is rendered.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 13, 2026
…2009627)

The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf.
When those annotations are added to the DOM, the struct tree has to be rendered but without
the text layer (because of asynchronicity).
So this patch is making sure that the modifications in the text layer are done once the
layer is rendered.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 13, 2026
…2009627)

The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf.
When those annotations are added to the DOM, the struct tree has to be rendered but without
the text layer (because of asynchronicity).
So this patch is making sure that the modifications in the text layer are done once the
layer is rendered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants