Skip to content

fix: deleteAnnotationElement takes a full editor object#20413

Merged
calixteman merged 1 commit intomozilla:masterfrom
sachiniyer:siyer/fix-annotation-editor-deletion
Nov 21, 2025
Merged

fix: deleteAnnotationElement takes a full editor object#20413
calixteman merged 1 commit intomozilla:masterfrom
sachiniyer:siyer/fix-annotation-editor-deletion

Conversation

@sachiniyer
Copy link
Contributor

@sachiniyer sachiniyer commented Nov 1, 2025

I noticed that addDeletedAnnotationElement takes an editor object not an annotation element id. I think this is papered over by the creation of a fake editor, which then results in the deletion of the annotation.

However, I think this change preserves the types, and keeps the deletion list accurate.

@calixteman
Copy link
Contributor

calixteman commented Nov 1, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 1, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dae3c6d7b9d0885/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 1, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6f739c5c046b4d4/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 1, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/dae3c6d7b9d0885/output.txt

Total script time: 19.63 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 1, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6f739c5c046b4d4/output.txt

Total script time: 42.41 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor

calixteman commented Nov 1, 2025

So it's a fixing a real issue I can easily reproduce in moving an existing annotation from a page to another.
I created a pdf with two pages and a stamp annotation on the bottom of the first page:
firefox_stamp.pdf
Would it be possible to write an integration test pretty similar to:

pdf.js/test/integration/stamp_editor_spec.mjs

Lines 1420 to 1445 in 2cc809a

it("must move an annotation", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
const modeChangedHandle = await waitForAnnotationModeChanged(page);
await page.click(getAnnotationSelector("25R"), { count: 2 });
await awaitPromise(modeChangedHandle);
const editorSelector = getEditorSelector(0);
await waitForSelectedEditor(page, editorSelector);
const editorIds = await getEditors(page, "stamp");
expect(editorIds.length).withContext(`In ${browserName}`).toEqual(5);
// All the current annotations should be serialized as null objects
// because they haven't been edited yet.
const serialized = await getSerialized(page);
expect(serialized).withContext(`In ${browserName}`).toEqual([]);
// Select the annotation we want to move.
await selectEditor(page, editorSelector);
await dragAndDrop(page, editorSelector, [[100, 100]]);
await waitForSerialized(page, 1);
})
);
});
});
?
The zoom level must be small enough to be sure we've the two pages in the view and then move the stamp from page 1 to the top of page 2 to make sure that everything is fine.
In order to just run your test you can set fdescribe or fit on it and then run it with npx gulp integrationtest.
Tell me if you don't want to write it and I'll merge your PR and will do a follow-up with a test.

@sachiniyer
Copy link
Contributor Author

sachiniyer commented Nov 1, 2025 •
edited
Loading

I added an integration test, and checked that it fails without this change (unfamiliar with the testing framework, so please lmk if there is a better way to write it).

timvandermeij
timvandermeij reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please squash the commits into one after addressing the comment, and then we can trigger the integration tests on the bots.

@sachiniyer sachiniyer force-pushed the siyer/fix-annotation-editor-deletion branch from bc53e29 to 7d55b6e Compare November 3, 2025 21:21
@sachiniyer
Copy link
Contributor Author

sachiniyer commented Nov 3, 2025

Hey @timvandermeij thanks for taking a look!

I've addressed the comment and squashed the changes together.

timvandermeij
timvandermeij approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with passing integration tests; thank you! @calixteman Feel free to merge this if you're also OK with this version.

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 6, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/431e3b62645872c/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/497750ef6abd11f/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/431e3b62645872c/output.txt

Total script time: 20.22 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/497750ef6abd11f/output.txt

Total script time: 44.75 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij requested changes Nov 8, 2025
View reviewed changes
@sachiniyer sachiniyer force-pushed the siyer/fix-annotation-editor-deletion branch from 8a2569e to 4a87426 Compare November 9, 2025 23:04
@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 11, 2025

The change looks good to me; let's see what the bots think about it:

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 11, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/11886da4e0b7350/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 11, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8d7e9c01cc9a033/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 11, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/11886da4e0b7350/output.txt

Total script time: 20.02 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 11, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8d7e9c01cc9a033/output.txt

Total script time: 45.75 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor

calixteman commented Nov 17, 2025

@sachiniyer the newly added test is failing on both bots. Do you plan to fix it ?

@sachiniyer
Copy link
Contributor Author

sachiniyer commented Nov 19, 2025

@sachiniyer the newly added test is failing on both bots. Do you plan to fix it ?

Hi @calixteman, sorry for the delay. Let me give this one more shot tomorrow. These are running correctly on my local machine (with the fdescribe that you mentioned), but are obviously failing in this CI.

@calixteman
Copy link
Contributor

calixteman commented Nov 21, 2025 •
edited
Loading

The test pdf file isn't a part of the patch... there's no chance it works, please add it. Thank you.

@sachiniyer sachiniyer force-pushed the siyer/fix-annotation-editor-deletion branch from 4a87426 to 464dae1 Compare November 21, 2025 19:32
@sachiniyer
Copy link
Contributor Author

sachiniyer commented Nov 21, 2025

The test pdf file isn't a part of the patch... there's no chance it works, please add it. Thank you.

Wow that is a pretty big miss. My bad. I've added it and reverified that the test pass on my local env. Can you re-run the tests @calixteman?

@calixteman
Copy link
Contributor

calixteman commented Nov 21, 2025

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6df24a5cd8ee3f7/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f56a8936821a446/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f56a8936821a446/output.txt

Total script time: 20.23 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 21, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6df24a5cd8ee3f7/output.txt

Total script time: 41.42 mins

  • Integration Tests: FAILED

calixteman
calixteman approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit b41959b into mozilla:master Nov 21, 2025
9 checks passed
@timvandermeij timvandermeij removed their request for review November 22, 2025 12:42
MightyPrytanis added a commit to MightyPrytanis/codebase that referenced this pull request Dec 28, 2025
@MightyPrytanis
[Snyk] Upgrade pdfjs-dist from 5.4.394 to 5.4.449 (#88)
6169fd3 
![snyk-top-banner](https://res.cloudinary.com/snyk/image/upload/r-d/scm-platform/snyk-pull-requests/pr-banner-default.svg)


<h3>Snyk has created this PR to upgrade pdfjs-dist from 5.4.394 to
5.4.449.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released **25 days ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>pdfjs-dist</b></summary>
    <ul>
      <li>
<b>5.4.449</b> - <a
href="https://redirect.github.com/mozilla/pdf.js/releases/tag/v5.4.449">2025-11-29</a></br><p>This
release contains improvements for the annotation editor, performance,
text selection and the viewer.</p>
<h2>Changes since v5.4.394</h2>
<ul>
<li>Bump the stable version in <code>pdfjs.config</code> by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3579487336" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20414"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20414/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20414">#20414</a></li>
<li>Create the number tree for the ParentTree only one time by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3591816984" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20425"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20425/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20425">#20425</a></li>
<li>Add the possibility to create a pdf from different ones (bug <a
class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038"><tt>1997379</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3571815078" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20409"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20409/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20409">#20409</a></li>
<li>Update the page labels tree when a pdf is extracted (bug <a
class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038"><tt>1997379</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3575545374" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20411"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20411/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20411">#20411</a></li>
<li>Update the named page destinations when some pdf are combined (bug
<a class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038"><tt>1997379</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3587968590" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20421"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20421/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20421">#20421</a></li>
<li>Version entry in the catalog has to be a name and not a string by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3605072148" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20432"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20432/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20432">#20432</a></li>
<li>Add a wrapper for the new xref in order to be able to get some
values from cloned dictionaries by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3605067263" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20431"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20431/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20431">#20431</a></li>
<li>Update dependencies and translations to the most recent versions by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3603833664" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20429"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20429/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20429">#20429</a></li>
<li>Introduce a helper function to create a freetext editor in the
integration tests by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3604971185" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20430"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20430/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20430">#20430</a></li>
<li>Add telemetry for tagged pdfs (bug <a class="commit-link"
data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/19971345aa78d05a3e1c11bc3a7538b332138ae1/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/19971345aa78d05a3e1c11bc3a7538b332138ae1"><tt>1997134</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3566590013" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20405"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20405/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20405">#20405</a></li>
<li>Merge the structure trees coming from different pdfs (bug <a
class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/1997379c2b90d8936f1de59fb8132b688b3b1038"><tt>1997379</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3614021374" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20436"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20436/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20436">#20436</a></li>
<li>Add regression test for PR 19184 by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/maettuu/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/maettuu">@ maettuu</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3296185417" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20151"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20151/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20151">#20151</a></li>
<li>Bump glob by <a class="user-mention notranslate"
data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot] in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3639302546" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20448"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20448/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20448">#20448</a></li>
<li>Bump js-yaml from 3.14.1 to 3.14.2 by <a class="user-mention
notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot] in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3639802138" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20449"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20449/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20449">#20449</a></li>
<li>Lint and format the HTML in using Prettier by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3639004748" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20447"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20447/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20447">#20447</a></li>
<li>Add setter for some FontFaceObject properties by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Aditi-1400/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Aditi-1400">@ Aditi-1400</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3597370951" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20427"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20427/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20427">#20427</a></li>
<li>fix: deleteAnnotationElement takes a full editor object by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/sachiniyer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/sachiniyer">@ sachiniyer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3576907181" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20413"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20413/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20413">#20413</a></li>
<li>When searching for a group of punctuation signs, only add
extraspaces around the group by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3652607726" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20456"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20456/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20456">#20456</a></li>
<li>[XFA] Set default max value in occur tag to -1 (bug 1998843) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3652413762" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20455"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20455/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20455">#20455</a></li>
<li>Bump actions/checkout from 5 to 6 by <a class="user-mention
notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot] in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3658722045" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20459"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20459/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20459">#20459</a></li>
<li>Include missing <code>cached-iterable</code> dev dependency in
<code>package.json</code> by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/Mario34/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Mario34">@ Mario34</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3640962782" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20450"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20450/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20450">#20450</a></li>
<li>Don't use firstChild/lastChild when getting elements (follow-up of
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3639004748" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20447"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20447/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20447">#20447</a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3655035626" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20458"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20458/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20458">#20458</a></li>
<li>[Editor] Allow to save an edited comment in using CTRL+Enter
shortcut. by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3660336947" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20460"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20460/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20460">#20460</a></li>
<li>Create a sidebar object by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3672692849" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20467"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20467/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20467">#20467</a></li>
<li>Fix the regex string used to find the chars to normalize with NFKC
when searching by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3671522388" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20465"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20465/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20465">#20465</a></li>
<li>Use OIDC trusted publishing in the GitHub Actions release workflow
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3675821902" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20468"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20468/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20468">#20468</a></li>
<li>Slightly reduce the memory used by thumbnails by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3664656889" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20462"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20462/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20462">#20462</a></li>
</ul>
      </li>
      <li>
<b>5.4.394</b> - <a
href="https://redirect.github.com/mozilla/pdf.js/releases/tag/v5.4.394">2025-11-02</a></br><p>This
release contains improvements for the annotation editor, accessibility,
font conversion and performance.</p>
<h2>Changes since v5.4.296</h2>
<ul>
<li>Bump the stable version in <code>pdfjs.config</code> by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3484979781" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20339"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20339/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20339">#20339</a></li>
<li>Update dependencies and translations to the most recent versions by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3484797970" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20337"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20337/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20337">#20337</a></li>
<li>[Editor] Remove obsolete arguments for <code>setDims</code> calls in
the highlight code by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3484736972" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20335"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20335/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20335">#20335</a></li>
<li>Add a test for PR <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="3468326930"
data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20320"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20320/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20320">#20320</a>
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3484806873" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20338"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20338/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20338">#20338</a></li>
<li>[Editor] Make sure that comment stuff is removed when an editor is
deleted (bug 1992987) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3492314726" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20342"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20342/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20342">#20342</a></li>
<li>[Editor] Make sure the editor is focused after the comment has been
deleted (bug 1992832) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3492605230" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20343"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20343/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20343">#20343</a></li>
<li>[Editor] Make sure all editors are focusable with the keyboard (bug
1992868) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3491333379" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20341"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20341/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20341">#20341</a></li>
<li>[Editor] Remove the role radio for the editing buttons (bug 1990826)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3495295238" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20347"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20347/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20347">#20347</a></li>
<li>[Editor] Make sure that annotation positions in the DOM respect the
visual order (bug 1992770) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3492670359" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20344"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20344/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20344">#20344</a></li>
<li>[Annotation] Use the annotations rect in order to fix the order in
the DOM (bug 1987914) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3496514142" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20350"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20350/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20350">#20350</a></li>
<li>[Editor] Avoid to have a null button in the DOM when there's no
comment manager by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3497967110" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20351"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20351/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20351">#20351</a></li>
<li>Improve performance of the struct tree build (bug 1987914) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3499363209" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20352"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20352/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20352">#20352</a></li>
<li>[Annotation] Improve the performance of the code for getting glyphs
which belongs to annotations bounding boxes (bug 1987914) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3500282005" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20353"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20353/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20353">#20353</a></li>
<li>Use enums instead of string for mesh shading figure type by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Aditi-1400/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Aditi-1400">@ Aditi-1400</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3500843377" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20354"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20354/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20354">#20354</a></li>
<li>Bump github/codeql-action from 3 to 4 by <a class="user-mention
notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot] in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3509915327" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20357"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20357/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20357">#20357</a></li>
<li>Very slightly improve intersector performance by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3509973536" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20358"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20358/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20358">#20358</a></li>
<li>Use Python 3.14 in the GitHub workflows by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3515253500" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20363"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20363/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20363">#20363</a></li>
<li>Update dependencies and translations to the most recent versions by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3507688665" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20356"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20356/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20356">#20356</a></li>
<li>Reset <code>sameLineText</code> dependencies data on
<code>setTextMatrix</code> by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/nicolo-ribaudo/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/nicolo-ribaudo">@ nicolo-ribaudo</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3514344708" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20361"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20361/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20361">#20361</a></li>
<li>Use a binary format for the glyph paths by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3520572543" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20367"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20367/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20367">#20367</a></li>
<li>[Editor] Correctly focus the annotation once the comment has been
removed in the annotation layer (bug 1994738) by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3522089657" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20369"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20369/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20369">#20369</a></li>
<li>[Editor] Fix the tooltip of the comment button when in the editor
toolbar (bug <a class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/1994958fe68886d6f9b6cfda6b3744877388ec47/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/1994958fe68886d6f9b6cfda6b3744877388ec47"><tt>1994958</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3526255526" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20372"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20372/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20372">#20372</a></li>
<li>[Editor] FreeText annotations aren't supposed to have an attached
popup so disable commenting for them (bug <a class="commit-link"
data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/19950281ae3f363c2a7da5d5e8721e06584e734f/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/19950281ae3f363c2a7da5d5e8721e06584e734f"><tt>1995028</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3526807632" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20374"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20374/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20374">#20374</a></li>
<li>[Editor] Make sure the color picker has the right color when pasting
an editor by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3526975641" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20375"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20375/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20375">#20375</a></li>
<li>[Editor] Fix integration test after <a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="3526255526" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20372"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20372/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20372">#20372</a>
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3527159739" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20377"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20377/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20377">#20377</a></li>
<li>Use stream for whatever substrem in stream classes by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3526702103" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20373"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20373/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20373">#20373</a></li>
<li>Fix stream use when getting the text (follow-up of <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3526702103" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20373"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20373/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20373">#20373</a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3529199081" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20379"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20379/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20379">#20379</a></li>
<li>Add a highlightSpan function in order to simplify a bit the
integration tests by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3507002860" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20355"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20355/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20355">#20355</a></li>
<li>Tweak the "scroll into view" viewer integration test by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3530186898" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20380"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20380/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20380">#20380</a></li>
<li>Don't use the <code>aboutstacks.pdf</code> file in the integration
tests by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3529113328" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20378"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20378/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20378">#20378</a></li>
<li>Bump actions/setup-node from 5 to 6 by <a class="user-mention
notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot] in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3532348368" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20381"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20381/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20381">#20381</a></li>
<li>Serialize pattern data into ArrayBuffer by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Aditi-1400/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Aditi-1400">@ Aditi-1400</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3486396344" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20340"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20340/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20340">#20340</a></li>
<li>[Editor] Fix the css of the button to close the comment sidebar (bug
1995766) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3541025584" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20386"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20386/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20386">#20386</a></li>
<li>[Editor] Fix the css of the link in the comment sidebar (bug
1995721) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3541081670" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20387"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20387/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20387">#20387</a></li>
<li>[Editor] Avoid to have several Undo entries in the context menu (bug
1995705) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3541768126" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20388"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20388/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20388">#20388</a></li>
<li>[Editor] Make sure the left (resp. right) corner of the popup is
visible when in LTR (resp. RTL) (bug 1995579) by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3542340134" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20389"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20389/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20389">#20389</a></li>
<li>Make MathML elements visible in the struct tree (bug <a
class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/mozilla/pdf.js/commit/1937438237e3f8cbc605070f5b352dde0a948d19/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/commit/1937438237e3f8cbc605070f5b352dde0a948d19"><tt>1937438</tt></a>)
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3537542227" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20384"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20384/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20384">#20384</a></li>
<li>Bump actions/upload-artifact from 4 to 5 by <a class="user-mention
notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot] in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3556679328" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20400"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20400/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20400">#20400</a></li>
<li>Update dependencies and translations to the most recent versions by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/timvandermeij/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/timvandermeij">@ timvandermeij</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3554151598" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20396"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20396/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20396">#20396</a></li>
<li>Add the font PT Astra Serif as a possible substitution for Times New
Roman by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/CoelacanthusHex/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/CoelacanthusHex">@ CoelacanthusHex</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3548776940" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20394"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20394/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20394">#20394</a></li>
<li>Collect all child nodes of lists and tables in StructTree by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/edoardocavazza/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/edoardocavazza">@ edoardocavazza</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3476674417" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20327"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20327/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20327">#20327</a></li>
<li>Add text extractor as an external service by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/gregtatum/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/gregtatum">@ gregtatum</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3567269308" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20406"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20406/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20406">#20406</a></li>
<li>Revert "Add some telemetry in order to know what are the
certificates used in pdfs (bug 1973573)" by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3566356381" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20404"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20404/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20404">#20404</a></li>
<li>Don't set the MathML namespace for attributes in MathML tags (bug
1997343) by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/calixteman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/calixteman">@ calixteman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3571149033" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20408"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20408/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20408">#20408</a></li>
<li>[Editor] A new CurrentPointers class to store current pointers used
by the editor by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/legraina/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/legraina">@ legraina</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="3368545207" data-permission-text="Title is private"
data-url="https://github.com/mozilla/pdf.js/issues/20213"
data-hovercard-type="pull_request"
data-hovercard-url="/mozilla/pdf.js/pull/20213/hovercard"
href="https://redirect.github.com/mozilla/pdf.js/pull/20213">#20213</a></li>
</ul>
      </li>
    </ul>
from <a
href="https://redirect.github.com/mozilla/pdf.js/releases">pdfjs-dist
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyNzUzNDk3MS1hNGZlLTQ4ZGItYTQ2Yi03Mjg1NTA3MTFiYWYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjI3NTM0OTcxLWE0ZmUtNDhkYi1hNDZiLTcyODU1MDcxMWJhZiJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/mightyprytanis/project/bcb5f568-d266-4cb2-8e80-1c9ebed57c1b?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mightyprytanis/project/bcb5f568-d266-4cb2-8e80-1c9ebed57c1b/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mightyprytanis/project/bcb5f568-d266-4cb2-8e80-1c9ebed57c1b/settings/integration?pkg&#x3D;pdfjs-dist&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"breakingChangeRiskLevel":null,"FF_showPullRequestBreakingChanges":false,"FF_showPullRequestBreakingChangesWebSearch":false,"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"pdfjs-dist","from":"5.4.394","to":"5.4.449"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"27534971-a4fe-48db-a46b-728550711baf","prPublicId":"27534971-a4fe-48db-a46b-728550711baf","packageManager":"npm","priorityScoreList":[],"projectPublicId":"bcb5f568-d266-4cb2-8e80-1c9ebed57c1b","projectUrl":"https://app.snyk.io/org/mightyprytanis/project/bcb5f568-d266-4cb2-8e80-1c9ebed57c1b?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-11-29T14:53:54.296Z"},"vulns":[]}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij requested changes

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sachiniyer @calixteman @moz-tools-bot @timvandermeij