[Editor] Don't throw when switching to editing mode before an annotation editor layer is rendered#20259
Merged
timvandermeij merged 1 commit intomozilla:masterfrom Sep 11, 2025
Conversation
…ion editor layer is rendered It can happen with a pdf having a large text layer. Instead of waiting for the first rendered page to enable the buttons we wait for a rendered annotation editor layer.
timvandermeij
approved these changes
Sep 11, 2025
Contributor
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing integration tests. Nice find!
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8f8c7cb78f194e5/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/25a4637992d041b/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8f8c7cb78f194e5/output.txt Total script time: 18.19 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/25a4637992d041b/output.txt Total script time: 43.62 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen with a pdf having a large text layer. Instead of waiting for the first rendered page to enable the buttons we wait for a rendered annotation editor layer.