Only record bboxes when needed#20256
Conversation
Before this patch, when `enableOptimizedPartialRendering` is enabled we would record the bounding boxes of the various operations on the first render. This patches change it to happen on the first render that we know will also need a detail view, so that the performance cost is not paid for the case when the detail view is not used.
af05a8b to
5de14aa
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 1 Live output at: http://54.241.84.105:8877/16f5ec6599b7638/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 1 Live output at: http://54.193.163.58:8877/e2f63b373fdf27e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/16f5ec6599b7638/output.txt Total script time: 37.15 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e2f63b373fdf27e/output.txt Total script time: 76.51 mins
|
|
/botio test-windows |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8cf4992e8980f79/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1a1dcf4f00e7313/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8cf4992e8980f79/output.txt Total script time: 37.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1a1dcf4f00e7313/output.txt Total script time: 76.05 mins
|
|
Thank you! |
Before this patch, when
enableOptimizedPartialRenderingis enabled we would record the bounding boxes of the
various operations on the first render.
This patch changes it to happen on the first render that we
know will also need a detail view, so that the performance
cost is not paid for the case when the detail view is not used.