Skip to content

Only record bboxes when needed#20256

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
nicolo-ribaudo:bboxes-when-needed
Sep 14, 2025
Merged

Only record bboxes when needed#20256
timvandermeij merged 1 commit intomozilla:masterfrom
nicolo-ribaudo:bboxes-when-needed

Conversation

@nicolo-ribaudo
Copy link
Contributor

@nicolo-ribaudo nicolo-ribaudo commented Sep 9, 2025

Before this patch, when enableOptimizedPartialRendering
is enabled we would record the bounding boxes of the
various operations on the first render.

This patch changes it to happen on the first render that we
know will also need a detail view, so that the performance
cost is not paid for the case when the detail view is not used.

Before this patch, when `enableOptimizedPartialRendering`
is enabled we would record the bounding boxes of the
various operations on the first render.

This patches change it to happen on the first render that we
know will also need a detail view, so that the performance
cost is not paid for the case when the detail view is not used.
@nicolo-ribaudo
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 1

Live output at: http://54.241.84.105:8877/16f5ec6599b7638/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 1

Live output at: http://54.193.163.58:8877/e2f63b373fdf27e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/16f5ec6599b7638/output.txt

Total script time: 37.15 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e2f63b373fdf27e/output.txt

Total script time: 76.51 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

@nicolo-ribaudo
Copy link
Contributor Author

/botio test-windows

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8cf4992e8980f79/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1a1dcf4f00e7313/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8cf4992e8980f79/output.txt

Total script time: 37.58 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/1a1dcf4f00e7313/output.txt

Total script time: 76.05 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit e78c7d0 into mozilla:master Sep 14, 2025
7 checks passed
@timvandermeij
Copy link
Contributor

Thank you!

@nicolo-ribaudo nicolo-ribaudo deleted the bboxes-when-needed branch September 14, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants