Fix the rendering of XFA rich text in popup annotations#20238
Merged
calixteman merged 1 commit intomozilla:masterfrom Sep 7, 2025
Merged
Fix the rendering of XFA rich text in popup annotations#20238calixteman merged 1 commit intomozilla:masterfrom
calixteman merged 1 commit intomozilla:masterfrom
Conversation
Before the introduction of the `renderRichText` helper function we exclusively used `this.#html` for XFA rich text and exclusively used `this.#contentsObj` for plain text. However, after the refactoring we tried to access `this.#contentsObj.dir` in both cases, which fails for XFA rich text because `this.#contentsObj` is `null` in that case. This commit fixes the issue by using optional chaining to make sure we don't try to access non-existent `this.#contentsObj` properties, which makes the `must update an existing annotation and show the right popup` freetext integration pass again. Fixes mozilla#20237. Fixes 35c9098.
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5c6e7537f1771fa/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/349fa40d8aabfbc/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5c6e7537f1771fa/output.txt Total script time: 18.17 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/349fa40d8aabfbc/output.txt Total script time: 39.31 mins
|
calixteman
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the introduction of the
renderRichTexthelper function we exclusively usedthis.#htmlfor XFA rich text and exclusively usedthis.#contentsObjfor plain text. However, after the refactoring we tried to accessthis.#contentsObj.dirin both cases, which fails for XFA rich text becausethis.#contentsObjisnullin that case.This commit fixes the issue by using optional chaining to make sure we don't try to access non-existent
this.#contentsObjproperties, which makes themust update an existing annotation and show the right popupfreetext integration pass again.Fixes #20237.
Fixes 35c9098.