Skip to content

[Editor] Add a Rect entry to a saved popup in order to avoid to have an invalid pdf#20179

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:add_rect_popup
Aug 24, 2025
Merged

[Editor] Add a Rect entry to a saved popup in order to avoid to have an invalid pdf#20179
calixteman merged 1 commit intomozilla:masterfrom
calixteman:add_rect_popup

Conversation

@calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

Not having the Rect was making Acrobat unhappy when moving an annotation with a comment.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Looks good!

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/412e5fd42b63b38/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e6f1749b56c4ec9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/e6f1749b56c4ec9/output.txt

Total script time: 60.00 mins

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/412e5fd42b63b38/output.txt

Total script time: 67.68 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: Passed

@calixteman calixteman merged commit 592d6c0 into mozilla:master Aug 24, 2025
9 checks passed
@calixteman calixteman deleted the add_rect_popup branch August 24, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants