Update dependencies and translations to the most recent versions by timvandermeij · Pull Request #20169 · mozilla/pdf.js

timvandermeij · 2025-08-16T14:40:38Z

The Puppeteer update contains puppeteer/puppeteer@21de026 which is a nice improvement for debugging problems or intermittents.

I tried it locally and it turns the following logs from the old version:

1) find bar highlight all (XFA) must search xfa correctly
  Message:
    ProtocolError: Waiting for selector `.xfaLayer .highlight2` failed: script.callFunction timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.
  Stack:
        at <instance_members_initializer> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:98:14)
        at new Callback (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:102:16)
        at CallbackRegistry.create (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:21:26)
        at BidiConnection.send (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/Connection.js:51:32)
        at Session.send (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/core/Session.js:134:42)
        at Session.<anonymous> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/util/decorators.js:101:27)
        at WindowRealm.callFunction (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/core/Realm.js:92:51)
        at WindowRealm.<anonymous> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/util/decorators.js:101:27)
        at #evaluate (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/Realm.js:134:42)
        at BidiFrameRealm.evaluateHandle (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/bidi/Realm.js:101:36)

into the following logs in the new version:

1) find bar highlight all (XFA) must search xfa correctly
  Message:
    Error: Waiting for selector `.xfaLayer .highlight2` failed
  Stack:
    error properties: Object({ cause: Error: Waiting failed })
        at CSSQueryHandler.waitFor (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/QueryHandler.js:211:46)
        at async CdpFrame.waitForSelector (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/api/Frame.js:545:21)
        at async CdpPage.waitForSelector (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/api/Page.js:1378:20)
        at async file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/test/integration/find_spec.mjs:107:11
        at async Promise.all (index 1)
        at async UserContext.<anonymous> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/test/integration/find_spec.mjs:101:7)
    Caused by: Error: Waiting failed
    error properties: Object({ cause: ProtocolError: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed. })
        at <instance_members_initializer> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/WaitTask.js:21:21)
        at new WaitTask (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/WaitTask.js:27:16)
        at IsolatedWorld.waitForFunction (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/api/Realm.js:22:26)
        at CSSQueryHandler.waitFor (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/QueryHandler.js:176:95)
        at async CdpFrame.waitForSelector (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/api/Frame.js:545:21)
        at async CdpPage.waitForSelector (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/api/Page.js:1378:20)
        at async file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/test/integration/find_spec.mjs:107:11
        at async Promise.all (index 1)
        at async UserContext.<anonymous> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/test/integration/find_spec.mjs:101:7)
    Caused by: ProtocolError: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.
        at <instance_members_initializer> (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:98:14)
        at new Callback (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:102:16)
        at CallbackRegistry.create (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:21:26)
        at Connection._rawSend (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/Connection.js:95:26)
        at CdpCDPSession.send (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/CdpSession.js:70:33)
        at #evaluate (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:360:50)
        at ExecutionContext.evaluateHandle (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:326:36)
        at IsolatedWorld.evaluateHandle (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/IsolatedWorld.js:86:30)
        at CdpJSHandle.evaluateHandle (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/api/JSHandle.js:154:37)
        at WaitTask.rerun (file:///home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer-core/lib/esm/puppeteer/common/WaitTask.js:99:47)

Note how the location of the problematic wait statement, find_spec.mjs:101:7, is nowhere to be found in the first traceback but is visible in the second, and that is really helpful information especially for intermittents that can't easily be reproduced locally.

timvandermeij · 2025-08-16T14:45:05Z

/botio-linux preview

moz-tools-bot · 2025-08-16T14:45:07Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3633a3c36173200/output.txt

moz-tools-bot · 2025-08-16T14:46:13Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3633a3c36173200/output.txt

Total script time: 1.08 mins

Published

Viewer: http://54.241.84.105:8877/3633a3c36173200/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/3633a3c36173200/legacy/web/viewer.html

timvandermeij · 2025-08-16T14:46:40Z

/botio test

timvandermeij · 2025-08-16T17:08:15Z

/botio test

moz-tools-bot · 2025-08-16T17:08:17Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b9827479b67e87c/output.txt

moz-tools-bot · 2025-08-16T17:08:17Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8a8126695139713/output.txt

moz-tools-bot · 2025-08-16T17:40:00Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8a8126695139713/output.txt

Total script time: 31.70 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: Passed

moz-tools-bot · 2025-08-16T18:11:26Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b9827479b67e87c/output.txt

Total script time: 63.14 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: Passed

timvandermeij · 2025-08-17T14:35:34Z

/botio test

moz-tools-bot · 2025-08-17T14:35:36Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/943c9e3e290828d/output.txt

moz-tools-bot · 2025-08-17T14:35:38Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b8ca507c3fa0b08/output.txt

moz-tools-bot · 2025-08-17T15:07:27Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/943c9e3e290828d/output.txt

Total script time: 31.85 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: Passed

moz-tools-bot · 2025-08-17T15:36:53Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b8ca507c3fa0b08/output.txt

Total script time: 61.22 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: Passed

calixteman

LGTM. Thank you.

timvandermeij requested a review from calixteman August 16, 2025 14:40

timvandermeij added dependencies l10n Localization labels Aug 16, 2025

mozilla deleted a comment from moz-tools-bot Aug 16, 2025

timvandermeij added 2 commits August 17, 2025 16:32

Update dependencies to the most recent versions

d49fc49

Update translations to the most recent versions

13de218

timvandermeij force-pushed the updates branch from 143449d to 13de218 Compare August 17, 2025 14:32

calixteman approved these changes Aug 19, 2025

View reviewed changes

calixteman merged commit 212547e into mozilla:master Aug 19, 2025
9 checks passed

timvandermeij deleted the updates branch August 19, 2025 18:04

Conversation

timvandermeij commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timvandermeij commented Aug 16, 2025

Uh oh!

moz-tools-bot commented Aug 16, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Aug 16, 2025

From: Bot.io (Linux m4)

Success

Published

Uh oh!

timvandermeij commented Aug 16, 2025

Uh oh!

timvandermeij commented Aug 16, 2025

Uh oh!

moz-tools-bot commented Aug 16, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Aug 16, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Aug 16, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Aug 16, 2025

From: Bot.io (Windows)

Failed

Uh oh!

timvandermeij commented Aug 17, 2025

Uh oh!

moz-tools-bot commented Aug 17, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Aug 17, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Aug 17, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Aug 17, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timvandermeij commented Aug 16, 2025 •

edited

Loading