Skip to content

[Editor] Add a floating button in order to highlight the text selection and add a comment (bug 1979381)#20119

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:comment_floating_button
Jul 28, 2025
Merged

[Editor] Add a floating button in order to highlight the text selection and add a comment (bug 1979381)#20119
calixteman merged 1 commit intomozilla:masterfrom
calixteman:comment_floating_button

Conversation

@calixteman
Copy link
Contributor

The callback called when clicking on the button is the same as the one trigged by clicking in the context menu (in m-c).

@calixteman calixteman requested a review from timvandermeij July 25, 2025 16:27
@calixteman calixteman requested a review from a team as a code owner July 25, 2025 16:27
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7e962627e4efbb4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7e962627e4efbb4/output.txt

Total script time: 0.94 mins

Published

@timvandermeij
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4a479b6e4341f48/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8d3727763772686/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/4a479b6e4341f48/output.txt

Total script time: 27.26 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/8d3727763772686/output.txt

Total script time: 41.77 mins

  • Integration Tests: FAILED

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and passing integration tests. Thank you!

…on and add a comment (bug 1979381)

The callback called when clicking on the button is the same as the one trigged by clicking in the context menu (in m-c).
@calixteman calixteman force-pushed the comment_floating_button branch from e5636c1 to 3fb7cd4 Compare July 28, 2025 13:32
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1f6d1fdaf1f8e16/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0be915710f3a81e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0be915710f3a81e/output.txt

Total script time: 13.46 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/1f6d1fdaf1f8e16/output.txt

Total script time: 29.17 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 995f070 into mozilla:master Jul 28, 2025
10 checks passed
@calixteman calixteman deleted the comment_floating_button branch July 28, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants