Skip to content

[Editor] Make possible to change the highlight color from the main panel#20098

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:update_highlight_color
Jul 17, 2025
Merged

[Editor] Make possible to change the highlight color from the main panel#20098
calixteman merged 1 commit intomozilla:masterfrom
calixteman:update_highlight_color

Conversation

@calixteman
Copy link
Contributor

It's consistent with the way to change colors for FreeText or Ink annotations.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d57a0a3ec272e00/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ab8f8982b323934/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ab8f8982b323934/output.txt

Total script time: 13.14 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d57a0a3ec272e00/output.txt

Total script time: 28.49 mins

  • Integration Tests: FAILED

@calixteman calixteman requested a review from timvandermeij July 16, 2025 16:26
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/e8f97e558e5fc76/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/e8f97e558e5fc76/output.txt

Total script time: 0.93 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed. Thank you for improving this!

It's consistent with the way to change colors for FreeText or Ink annotations.
@calixteman calixteman force-pushed the update_highlight_color branch from cf2c970 to 5162209 Compare July 17, 2025 18:57
@calixteman calixteman merged commit d2f8e60 into mozilla:master Jul 17, 2025
9 checks passed
@calixteman calixteman deleted the update_highlight_color branch July 17, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants