Assert that numberToString is called with a number (issue 19877)#19880
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2cc5edec377f77c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/df12c197946101f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/df12c197946101f/output.txt Total script time: 30.87 mins
Image differences available at: http://54.241.84.105:8877/df12c197946101f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2cc5edec377f77c/output.txt Total script time: 60.89 mins
Image differences available at: http://54.193.163.58:8877/2cc5edec377f77c/reftest-analyzer.html#web=eq.log |
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c00e2eef66c6ad2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c418c07b3321821/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c00e2eef66c6ad2/output.txt Total script time: 16.01 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c418c07b3321821/output.txt Total script time: 26.58 mins
|
|
@calixteman We could obviously just WONTFIX the issue instead, if you think that this change is unnecessary. |
|
I'd say this patch is useless especially because as you mentioned it's completely under our control and not exposed. |
Snuffleupagus
force-pushed
the
numberToString-assert-number
branch
from
d02121d to
98a5cc4
Compare
Sure, I've updated the patch to limit this code to development and TESTING modes. |
*NOTE:* Given that this is an *internal* function, used only in the worker-thread, it's not clear to me that this is an entirely "necessary" change.
Snuffleupagus
force-pushed
the
numberToString-assert-number
branch
from
98a5cc4 to
f5faf86
Compare
|
(The GitHub Actions were "stuck", not showing any results, so re-pushing this without any code changes to try and fix that.) |
3 participants
NOTE: Given that this is an internal function, used only in the worker-thread, it's not clear to me that this is an entirely "necessary" change.