Add a basic navigator polyfill for older Node.js versions#19876
Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom Apr 29, 2025
Merged
Add a basic navigator polyfill for older Node.js versions#19876Snuffleupagus merged 1 commit intomozilla:masterfrom
navigator polyfill for older Node.js versions#19876Snuffleupagus merged 1 commit intomozilla:masterfrom
Conversation
Modern Node.js versions now include a `navigator` implementation, with a few basic properties, that's actually enough for the PDF.js use-cases; please see https://nodejs.org/api/globals.html#navigator Unfortunately we still support Node.js version `20`, hence we add a basic polyfill since that allows simplifying the code slightly.
Collaborator
Author
|
/botio unittest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0764f00d01514cf/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f67de7cc43a58df/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0764f00d01514cf/output.txt Total script time: 2.37 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f67de7cc43a58df/output.txt Total script time: 8.14 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern Node.js versions now include a
navigatorimplementation, with a few basic properties, that's actually enough for the PDF.js use-cases; please see https://nodejs.org/api/globals.html#navigatorUnfortunately we still support Node.js version
20, hence we add a basic polyfill since that allows simplifying the code slightly.Smaller diff with https://github.com/mozilla/pdf.js/pull/19876/files?w=1