Skip to content

Enable the no-array-reduce ESLint plugin rule#19788

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:no-array-reduce
Apr 8, 2025
Merged

Enable the no-array-reduce ESLint plugin rule#19788
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:no-array-reduce

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Apr 8, 2025

Please see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-reduce.md

Note that this still allows "simple" usage of Array.prototype.reduce, however most of those cases will be possible to replace with Math.sumPrecise once that becomes generally available (currently not supported in Node.js or QuickJS).

@Snuffleupagus
Enable the no-array-reduce ESLint plugin rule
38d0125 
Please see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-reduce.md

Note that this still allows "simple" usage of `Array.prototype.reduce`, however most of those cases will be possible to replace with `Math.sumPrecise` once that becomes generally available (currently not supported in Node.js or QuickJS).
@calixteman
Copy link
Contributor

calixteman commented Apr 8, 2025 •
edited
Loading

About quickjs, for now Math.sumPrecise isn't implemented:
https://github.com/bellard/quickjs/blob/9d3776d0d45ca437ddb7f9079ae0367102abc90f/test262.conf#L154

but we can cheat something, see what I did for Date.parse:

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Apr 8, 2025

About quickjs, for now Math.sumPrecise isn't implemented: https://github.com/bellard/quickjs/blob/9d3776d0d45ca437ddb7f9079ae0367102abc90f/test262.conf#L154

but we can cheat something, see what I did for Date.parse:

* https://github.com/mozilla/pdf.js.quickjs/blob/3ca8f480cd32240378d5e53b759c5e14b76a3549/src/quickjs_extra.c#L118-L132

* https://github.com/mozilla/pdf.js.quickjs/blob/3ca8f480cd32240378d5e53b759c5e14b76a3549/src/myjs.js#L71-L74

* https://github.com/mozilla/pdf.js.quickjs/blob/3ca8f480cd32240378d5e53b759c5e14b76a3549/0001-Extra-stuff-for-use-with-PDF.js.patch#L36-L39

Interesting, thank you.

Given that Math.sumPrecise is new enough that it can still be disabled in Firefox (via a preference), we probably want to hold off using it in the scripting_api/ folder since we'd then need to bundle a polyfill anyway.

calixteman
calixteman approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 0e50125 into mozilla:master Apr 8, 2025
7 checks passed
@Snuffleupagus Snuffleupagus deleted the no-array-reduce branch April 8, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

other

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Snuffleupagus @calixteman