Merge pull request #20238 from timvandermeij/fix-freetext-permafail

calixteman · web-flow · commit d946de904c87 · 2025-09-07T20:59:36.000+02:00
Fix the rendering of XFA rich text in popup annotations
diff --git a/src/display/annotation_layer.js b/src/display/annotation_layer.js
@@ -2494,7 +2494,7 @@ class PopupElement {
     renderRichText(
       {
         html: this.#html || this.#contentsObj.str,
-        dir: this.#contentsObj.dir,
+        dir: this.#contentsObj?.dir,
         className: "popupContent",
       },
       popup

Original file line number	Diff line number	Diff line change
`@@ -2494,7 +2494,7 @@ class PopupElement {`
`2494`	`2494`	`renderRichText(`
`2495`	`2495`	`{`
`2496`	`2496`	`html: this.#html \|\| this.#contentsObj.str,`
`2497`		`- dir: this.#contentsObj.dir,`
	`2497`	`+ dir: this.#contentsObj?.dir,`
`2498`	`2498`	`className: "popupContent",`
`2499`	`2499`	`},`
`2500`	`2500`	`popup`