ensure timely cleanup of UserAgent temporary files#2300
Open
dakkar wants to merge 2 commits intomojolicious:mainfrom
Open
ensure timely cleanup of UserAgent temporary files#2300dakkar wants to merge 2 commits intomojolicious:mainfrom
dakkar wants to merge 2 commits intomojolicious:mainfrom
Conversation
the `$cb` that `sub start` passes to `sub _start` is:
sub { shift->ioloop->stop; $tx = shift }
which closes over `$tx`, which owns the response, its content, its
asset, and its tempfile (when the asset is a `Mojo::Asset::File`)
if we leave the callback inside the `{connections}` hashref, the
tempfile will not be cleaned up until the connection is next re-used,
which may not happen any time soon, especially for long-lived
applications that download data from many sources
deleting the callback just before calling it, ensures a timely cleanup
I've also added a test to prove the problem and the fix. All tests
pass.
kraih
reviewed
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that temporary files created by
Mojo::UserAgentare cleaned up as soon as the transaction is destroyed.Motivation
the
$cbthatsub startpasses tosub _startis:which closes over
$tx, which owns the response, its content, its asset, and its tempfile (when the asset is aMojo::Asset::File)if we leave the callback inside the
{connections}hashref, the tempfile will not be cleaned up until the connection is next re-used, which may not happen any time soon, especially for long-lived applications that download data from many sourcesdeleting the callback just before calling it, ensures a timely cleanup
I've also added a test to prove the problem and the fix. All tests pass.