Skip to content

Prevent desktop release build jobs from auto-publishing #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DragonnZhang merged 1 commit into from
Jun 8, 2026
Merged

Prevent desktop release build jobs from auto-publishing #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,13 @@ jobs:
include:
- name: macOS
os: macos-latest
command: bun run dist:mac
command: bun run dist:mac:no-publish
- name: Windows
os: windows-latest
command: bun run dist:win
command: bun run dist:win:no-publish
- name: Linux
os: ubuntu-22.04
command: bun run dist:linux
command: bun run dist:linux:no-publish

steps:
- name: Check out source
Expand Down Expand Up @@ -319,6 +319,9 @@ jobs:
append_env "SENTRY_ELECTRON_INGEST_URL" "$SENTRY_ELECTRON_INGEST_URL_SECRET"

- name: Build desktop installer
# Build jobs only produce artifacts. The publish job below owns GitHub
# Release creation/upload so dry-run, draft, prerelease, and replace
# behavior stays centralized.
run: ${{ matrix.command }}

- name: Upload installer artifacts
Expand Down
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
"dist:mac": "bun run electron:dist:mac",
"dist:win": "bun run electron:dist:win",
"dist:linux": "bun run electron:dist:linux",
"dist:mac:no-publish": "bun run electron:dist:mac:no-publish",
"dist:win:no-publish": "bun run electron:dist:win:no-publish",
"dist:linux:no-publish": "bun run electron:dist:linux:no-publish",
"test": "bun test && for f in $(find . -name '*.isolated.ts' -not -path './node_modules/*'); do bun test \"$f\" || exit 1; done",
"typecheck": "bun run typecheck:shared",
"typecheck:shared": "cd packages/shared && bun run tsc --noEmit",
Expand Down Expand Up @@ -89,6 +92,9 @@
"electron:dist:mac": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --mac",
"electron:dist:win": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --win",
"electron:dist:linux": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --linux",
"electron:dist:mac:no-publish": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --mac --publish never",
"electron:dist:win:no-publish": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --win --publish never",
"electron:dist:linux:no-publish": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --linux --publish never",
"electron:dist:dev:mac": "bun run electron:vendor:qwen && CSC_IDENTITY_AUTO_DISCOVERY=false CRAFT_DEV_RUNTIME=1 bun run electron:build && bun run electron:builder-config && cd apps/electron && CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder --config electron-builder.generated.yml --mac",
"electron:dist:dev:win": "bun run electron:vendor:qwen && CRAFT_DEV_RUNTIME=1 bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --win",
"electron:dist:dev:linux": "bun run electron:vendor:qwen && CRAFT_DEV_RUNTIME=1 bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --linux",
Expand Down