Prevent desktop release build jobs from auto-publishing#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--publish neverto electron-builder.Root Cause
After desktop auto-update metadata added a GitHub
publishconfig, electron-builder detected CI and defaulted toonTagOrDraft. The macOS, Windows, and Linux build jobs then tried to publish artifacts themselves, but those jobs do not setGH_TOKEN, so all three failed with:Validation
git diff --check.github/workflows/desktop-release.ymlwithjs-yamlpackage.json--publish neverbun run electron:builder-configNotes
--publish neverstill lets electron-builder generate updater metadata from thepublishconfig; it only disables uploader creation. The workflow's dedicated publish job remains responsible for Release creation/upload, including dry-run, draft, prerelease, and replace behavior.