client: Client.PluginList: add options-struct#51207
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 17, 2025
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/plugins
kind/refactor
thaJeztah
added
impact/changelog
area/go-sdk
impact/go-sdk
vvoland
approved these changes
Oct 17, 2025
thaJeztah
commented
Oct 17, 2025
Comment on lines
-12
to
+17
| func (cli *Client) PluginList(ctx context.Context, filter Filters) (plugin.ListResponse, error) { | ||
| func (cli *Client) PluginList(ctx context.Context, opts PluginListOptions) (plugin.ListResponse, error) { |
Member
Author
There was a problem hiding this comment.
FWIW; I did not yet change the return type here, so this one (and probably other list methods) will still need to go through one iteration once we have a good shape for those.
(This one was mostly to get the Filters out of the function signature itself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)