client: ImageBuildResponse: remove OSType field#50995
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 17, 2025
Merged
Conversation
thaJeztah
added
status/2-code-review
impact/deprecation
kind/refactor
This field was used in the CLI to produce a warning added in [moby/moby@4a8b3ca] to print a warning when building Linux images from a Windows client. Window's filesystem does not have an "executable" bit, which mean that, for example, copying a shell script to an image during build would lose the executable bit. So for Windows clients, the executable bit would be set on all files, unconditionally. Originally this was detected in the client, which had direct access to the API response headers, but when refactoring the client to use a common library in [moby/moby@535c4c9], this was refactored into a `ImageBuildResponse` wrapper, deconstructing the API response into an `io.Reader` and a string field containing only the `OSType` header. The warning was removed in [cli@af65ee4], so we don't have to carry this field in the new client module going forward. With the field removed, we can consider the client to return the full HTTP response again, but leaving that for a follow-up, as we may want to rewrite these streaming functions altogether. [moby/moby@4a8b3ca]: moby@4a8b3ca [moby/moby@535c4c9]: moby@535c4c9 [cli@af65ee4]: docker/cli@af65ee4 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
rm_build_ostype
branch
from
d76a377 to
82e5d30
Compare
vvoland
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
This field was used in the CLI to produce a warning added in moby@4a8b3ca to print a warning when building Linux images from a Windows client. Window's filesystem does not have an "executable" bit, which mean that, for example, copying a shell script to an image during build would lose the executable bit. So for Windows clients, the executable bit would be set on all files, unconditionally.
Originally this was detected in the client, which had direct access to the API response headers, but when refactoring the client to use a common library in moby@535c4c9, this was refactored into a
ImageBuildResponsewrapper, deconstructing the API response into anio.Readerand a string field containing only theOSTypeheader.The warning was removed in cli@af65ee4, so we don't have to carry this field in the new client module going forward.
With the field removed, we can consider the client to return the full HTTP response again, but leaving that for a follow-up, as we may want to rewrite these streaming functions altogether.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)