api/t/ctr: deprecate NetworkSettingsBase, DefaultNetworkSettings#50848
Merged
vvoland merged 4 commits intomoby:masterfrom Aug 29, 2025
Merged
api/t/ctr: deprecate NetworkSettingsBase, DefaultNetworkSettings#50848vvoland merged 4 commits intomoby:masterfrom
vvoland merged 4 commits intomoby:masterfrom
Conversation
This field provides little value as it's only set when the daemon is started with --bridge flag specified, and the inspected container is connected to the default bridge network. Unfortunately, there's no equivalent field in NetworkSettings.Networks. Signed-off-by: Albin Kerouanton <[email protected]>
Most fields in NetworkSettingsBase are deprecated, so deprecate the whole struct. The few fields which aren't deprecated will move to the NetworkSettings struct in v29. Signed-off-by: Albin Kerouanton <[email protected]>
Signed-off-by: Albin Kerouanton <[email protected]>
This struct is only used to report the networking state for the default bridge network when the container is connected to it. It was deprecated in v1.09 (API v1.21), and scheduled for removal in v1.11. Unfortunately, the deprecation warning was wrongly formatted in the Go code. However, deprecation warnings are already present in swagger.yaml, so don't touch it. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added
area/api
akerouanton
changed the title
vvoland
reviewed
Aug 29, 2025
vvoland
approved these changes
Aug 29, 2025
robmry
approved these changes
Aug 29, 2025
This was referenced Sep 5, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
api/t/ctr: deprecate NetworkSettingsBase.Bridge
This field provides little value as it's only set when the daemon is started with --bridge flag specified, and the inspected container is connected to the default bridge network.
Unfortunately, there's no equivalent field in NetworkSettings.Networks.
api/t/ctr: deprecate NetworkSettingsBase
Most fields in NetworkSettingsBase are deprecated, so deprecate the whole struct. The few fields which aren't deprecated will move to the NetworkSettings struct in v29.
api/t/ctr: deprecate DefaultNetworkSettings
This struct is only used to report the networking state for the default bridge network when the container is connected to it.
It was deprecated in v1.09 (API v1.21), and scheduled for removal in v1.11. Unfortunately, the deprecation warning was wrongly formatted in the Go code. However, deprecation warnings are already present in swagger.yaml, so don't touch it.
- Human readable description for the release notes