windows: do not forgot IPAM configuration when re-creating networks#50649
Merged
robmry merged 1 commit intomoby:masterfrom Aug 7, 2025
Merged
windows: do not forgot IPAM configuration when re-creating networks#50649robmry merged 1 commit intomoby:masterfrom
robmry merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Olli Janatuinen <[email protected]>
Contributor
Author
|
@robmry I think that you have worked in this area lately so PTAL |
robmry
added
platform/windows
area/networking
akerouanton
approved these changes
Aug 7, 2025
Contributor
|
Something tragic's happening in CI at the moment - but the test failures here (on Linux) can't be related to the changes. So, let's get this merged ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
I seems to be that no one else has actually tried to build production ready IPAM plugin for Windows because reloading of them has been broken since from original implementation #20478
So I updated network re-creation logic in way that we keep track which IPAM driver was used and what the options where used.
- How I did it
Storing old values to variables before removing old networks. Only exception is the case when network exists only in HNS but not in Docker. In that case we expect that it was created outside of Docker and mark IPAM driver to
default(which get replaced withwindowssomewhere else in code) like old behavior was.- How to verify it
CI should pass just fine because this does not change old behavior.
Actual IPAM plugin reloading cannot be tested in latest code in master branch until bug IPAM plugin loading is broken in Windows starting from Docker 27.0.1 is fixed but those who are interested can try my custom release 26.1.5-olljanat2.
- Human readable description for the release notes
- Windows: when restoring networks on daemon restart, preserve their association with non-default IPAM drivers