Skip to content

Fixes #62#76

Merged
aniketsharma00411 merged 4 commits into
mlcpp:mainfrom
ashok-arora:fix_62
Jan 8, 2021
Merged

Fixes #62#76
aniketsharma00411 merged 4 commits into
mlcpp:mainfrom
ashok-arora:fix_62

Conversation

@ashok-arora

Copy link
Copy Markdown
Member

Description

This PR ensures that CMake automatically downloads the dependencies at each build so that the developer doesn't have to mess around with installing external libraries.

Fixes #62

Type of change

  • New feature (non-breaking change which adds functionality)

@ashok-arora ashok-arora added the CMake Issues concerning CMake build system label Jan 6, 2021
@aniketsharma00411 aniketsharma00411 mentioned this pull request Jan 6, 2021
5 tasks
@ashok-arora ashok-arora marked this pull request as ready for review January 7, 2021 15:07
Comment thread README.md

Windows: `mingw32-make benchmarks`

## Testing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add testing in Table of Contents also.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@aniketsharma00411 aniketsharma00411 merged commit 20f58c9 into mlcpp:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake Issues concerning CMake build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] CMake should install google benchmark and googletest

2 participants