fixup! do not reverse in place, add a test for it.

mkrawczuk · mkrawczuk · commit 47eecd27cc7f · 2020-08-06T08:38:15.000+02:00
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -1435,8 +1435,8 @@ Server.prototype[EE.captureRejectionSymbol] = function(
 
 function SNICallback(servername, callback) {
   const contexts = this.server._contexts;
-
-  for (const elem of contexts.reverse()) {
+  for (let i = contexts.length - 1; i >= 0; --i) {
+    const elem = contexts[i];
     if (elem[0].test(servername)) {
       callback(null, elem[1]);
       return;
diff --git a/test/parallel/test-tls-secure-context-usage-order.js b/test/parallel/test-tls-secure-context-usage-order.js
@@ -83,7 +83,17 @@ server.listen(0, () => {
     });
 
     other.on('close', common.mustCall(() => {
-      server.close();
+      // 5. Make another connection using servername 'b.example.com' to ensure
+      // that the array of secure contexts is not reversed in place with each
+      // SNICallback call, as someone might be tempted to refactor this piece of
+      // code by using Array.prototype.reverse() method.
+      const onemore = tls.connect(options, () => {
+        onemore.end();
+      });
+
+      onemore.on('close', common.mustCall(() => {
+        server.close();
+      }));
     }));
   }));
 });
