Skip to content

Initial support for Checks API.#249

Merged
avsm merged 1 commit into
mirage:masterfrom
tmcgilchrist:checks_api
Jul 12, 2021
Merged

Initial support for Checks API.#249
avsm merged 1 commit into
mirage:masterfrom
tmcgilchrist:checks_api

Conversation

@tmcgilchrist
Copy link
Copy Markdown
Member

No description provided.

@tmcgilchrist tmcgilchrist marked this pull request as draft June 21, 2021 04:44
@avsm
Copy link
Copy Markdown
Member

avsm commented Jun 21, 2021

Looks good to me (the TODO with the enum is fine to leave for now). Do you want to deploy this in ocurrent and then merge here once that's working?

@tmcgilchrist
Copy link
Copy Markdown
Member Author

@avsm will do.
I added the doc strings and links to the GitHub pages, and a small cli program to poke at the API.

@tmcgilchrist tmcgilchrist marked this pull request as ready for review June 22, 2021 06:39
@avsm
Copy link
Copy Markdown
Member

avsm commented Jun 22, 2021

CI should go green now if you rebase to the master branch

@tmcgilchrist tmcgilchrist force-pushed the checks_api branch 3 times, most recently from ed66887 to 356f45a Compare June 29, 2021 05:51
@avsm avsm merged commit ec44bc1 into mirage:master Jul 12, 2021
@avsm
Copy link
Copy Markdown
Member

avsm commented Jul 12, 2021

Thanks!

tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Jul 13, 2021
CHANGES:

- Fixes to odoc warnings and cohttp dependencies (@Aaylor mirage/ocaml-github#244)
- Support for 4.12 and fixing recent compiler warnings (@tmcgilchrist mirage/ocaml-github#246 mirage/ocaml-github#252 and @emillon mirage/ocaml-github#250 mirage/ocaml-github#247 mirage/ocaml-github#251)
- Add a new package `github-data` which contains just the serialisation logic
  without a dependency on the web stack (mirage/ocaml-github#248 @emillon)
- Add Github checks API support (mirage/ocaml-github#249 @tmcgilchrist)
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Jul 21, 2021
CHANGES:

- Fixes to odoc warnings and cohttp dependencies (@Aaylor mirage/ocaml-github#244)
- Support cohttp 4.0. (@tmcgilchrist mirage/ocaml-github#257)
- Support for 4.12 and fixing recent compiler warnings (@tmcgilchrist mirage/ocaml-github#246 mirage/ocaml-github#252 and @emillon mirage/ocaml-github#250 mirage/ocaml-github#247 mirage/ocaml-github#251)
- Add a new package `github-data` which contains just the serialisation logic
  without a dependency on the web stack (mirage/ocaml-github#248 @emillon)
- Add Github checks API support (mirage/ocaml-github#249 @tmcgilchrist)
- Label field missing in branch refs for ghost (@dra27 and @tmcgilchrist mirage/ocaml-github#256)
- Get all commits for user/repo (@Stevendeo mirage/ocaml-github#245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants