Moved LSP to the latest version that has race fixed - #19136
Merged
Karthik Nadig (karthiknadig) merged 3 commits intoMay 12, 2022
Conversation
Heejae Chang (heejaechang)
requested a review
from Kim-Adeline Miguel (kimadeline)
May 12, 2022 16:46
Heejae Chang (heejaechang)
added
no-changelog
Author
|
Kartik Raj (@karrtikr) Kim-Adeline Miguel (@kimadeline) I confirmed this fix the race. once this is in, can we release point release? |
Kim-Adeline Miguel (kimadeline)
assigned
Kim-Adeline Miguel (kimadeline) and unassigned
Kartik Raj (karrtikr)
Kim-Adeline Miguel (kimadeline)
approved these changes
May 12, 2022
Kim-Adeline Miguel (kimadeline)
left a comment
Kim-Adeline Miguel (kimadeline)
left a comment
There was a problem hiding this comment.
Karthik Nadig (@karthiknadig) can we do another point-release with this fix?
Member
|
Certainly, can we add a news item to this. |
Author
|
Karthik Nadig (@karthiknadig) do we have issue number that I can use for news entry? |
Member
|
You can use this #19139 |
Author
Karthik Nadig (karthiknadig)
approved these changes
May 12, 2022
Karthik Nadig (karthiknadig)
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
May 12, 2022
* moved lsp to latest version that has race fixed * updated middleware * added news entry
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
May 12, 2022
* Indicate the Python output channel has to be manually filled in the issue template (#19130) * Moved LSP to the latest version that has race fixed (#19136) * moved lsp to latest version that has race fixed * updated middleware * added news entry * Fix news entry encoding. * Update versions and changelog Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Heejae Chang <[email protected]>
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…-python#19136) * moved lsp to latest version that has race fixed * updated middleware * added news entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.