Skip to content

Sort Settings Alphabetically #8406 - #16696

Merged
Karthik Nadig (karthiknadig) merged 4 commits into
microsoft:mainfrom
bfarahdel:main
Jul 15, 2021
Merged

Sort Settings Alphabetically #8406#16696
Karthik Nadig (karthiknadig) merged 4 commits into
microsoft:mainfrom
bfarahdel:main

Conversation

@bfarahdel

@bfarahdel Britny Farahdel (bfarahdel) commented Jul 15, 2021

Copy link
Copy Markdown

For #8406

Settings have been sorted alphabetically.

Open Source Day

BritsHub and others added 2 commits July 15, 2021 14:37
@ghost

Deleted user (ghost) commented Jul 15, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@eleanorjboyd Eleanor Boyd (eleanorjboyd) changed the title Issue #8406 Sort Settings Alphabetically #8406 Jul 15, 2021
@karthiknadig

Copy link
Copy Markdown
Member

Britny Farahdel (@bfarahdel) Thanks for the PR. Can you sort the items under "commands", "configuration", "properties"... by the name of the command, or configuration.

@karthiknadig

Copy link
Copy Markdown
Member

This looks good. Waiting for the tests to pass.

@karthiknadig

Copy link
Copy Markdown
Member

Britny Farahdel (@bfarahdel) One last thing so you can get credit for this in our change logs. The error you see means that you need a news item. Add a file 8406.md to news\3 Code Health with the following content:

Sort Settings Alphabetically (thanks [bfarahdel](https://github.com/bfarahdel))

news item
@kimadeline Kim-Adeline Miguel (kimadeline) added the skip package*.json package.json and package-lock.json don't both need updating label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants