Skip to content

Fix npm audit vulnerabilities - #16658

Closed
Paula (paulacamargo25) wants to merge 17 commits into
microsoft:mainfrom
paulacamargo25:16148-Fix-npm-audit-vulnerabilities
Closed

Fix npm audit vulnerabilities#16658
Paula (paulacamargo25) wants to merge 17 commits into
microsoft:mainfrom
paulacamargo25:16148-Fix-npm-audit-vulnerabilities

Conversation

@paulacamargo25

@paulacamargo25 Paula (paulacamargo25) commented Jul 12, 2021

Copy link
Copy Markdown

Closed #318.

Comment thread src/client/common/net/httpClient.ts
@paulacamargo25
Paula (paulacamargo25) marked this pull request as ready for review July 15, 2021 21:34
@karrtikr
Kartik Raj (karrtikr) removed their request for review July 15, 2021 22:55

@karrtikr Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I have left one comment which needs verification and tests that needs to be fixed.

Comment thread src/client/pythonEnvironments/common/pythonBinariesWatcher.ts
Comment thread src/client/pythonEnvironments/discovery/locators/services/windowsStoreLocator.ts Outdated
@paulacamargo25
Paula (paulacamargo25) force-pushed the 16148-Fix-npm-audit-vulnerabilities branch from f240a22 to d3cfa6e Compare July 21, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants