Revert "Revert "Add a locator for executables on $PATH on Windows."" - #15087
Merged
Eric Snow (ericsnowcurrently) merged 3 commits intoJan 5, 2021
Conversation
…icrosoft#14981)" This reverts commit 0837629.
github-actions
Bot
requested review from
Pavel Minaev (int19h) and
Kim-Adeline Miguel (kimadeline)
January 5, 2021 00:43
Kim-Adeline Miguel (kimadeline)
approved these changes
Jan 5, 2021
Pavel Minaev (int19h)
approved these changes
Jan 5, 2021
Eric Snow (ericsnowcurrently)
deleted the
revert-revert-windows-path-locator
branch
January 5, 2021 23:01
|
Eric Snow (@ericsnowcurrently) This is breaking insiders for the experiment folks, gave me some headache while I was debugging some other issue. So hopefully the fix #14994 is merged soon 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0837629. It unreverts 651a6b9 (#14981).
This was reviewed originally so should not need any new review.
Note that #14994 has the fix for the problem for which the original commit was reverted in the first place.