Fix unittest discovery when using VS Code Insiders by using Inversify's skipBaseClassChecks option. - #15049
Merged
Kim-Adeline Miguel (kimadeline) merged 3 commits intoJan 4, 2021
Conversation
added 2 commits
December 23, 2020 10:45
Kim-Adeline Miguel (kimadeline)
marked this pull request as ready for review
December 23, 2020 19:06
Kim-Adeline Miguel (kimadeline)
requested review from
Brett Cannon (brettcannon) and
Kartik Raj (karrtikr)
December 23, 2020 19:07
Kartik Raj (karrtikr)
approved these changes
Dec 23, 2020
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
Interesting, does this actually fix the unit test issue for you?
Author
|
Yep, and I checked, unit tests are still discovered when using VS Code stable, it doesn't seem to have broken anything as far as I can see. |
Codecov Report
@@ Coverage Diff @@
## main #15049 +/- ##
======================================
Coverage 65% 65%
======================================
Files 558 558
Lines 26231 26231
Branches 3728 3728
======================================
Hits 17155 17155
Misses 8381 8381
Partials 695 695 |
Brett Cannon (brettcannon)
approved these changes
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #14962
What
skipBaseClassCheckdoes: https://github.com/inversify/InversifyJS/blob/master/wiki/container_api.md#skipbaseclasschecksUnitTestSocketServer(which is causing the issue) extends fromEventEmitter, a Node class we don't control.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).