Remove control tower code for trusted notebooks - #13394
Merged
Joyce Er (joyceerhl) merged 2 commits intoAug 12, 2020
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #13394 +/- ##
==========================================
- Coverage 59.95% 59.92% -0.04%
==========================================
Files 670 670
Lines 37200 37186 -14
Branches 5311 5309 -2
==========================================
- Hits 22305 22284 -21
+ Misses 13773 13763 -10
- Partials 1122 1139 +17
Continue to review full report at Codecov.
|
| if (this.alwaysTrustNotebooks || !(await this.enabled)) { | ||
| return true; // Skip check if user manually overrode our trust checking, or if user is not in experiment | ||
| if (this.alwaysTrustNotebooks) { | ||
| return true; // Skip check if user manually overrode our trust checking |
There was a problem hiding this comment.
Updated comments 👍
Ian Huff (IanMatthewHuff)
approved these changes
Aug 12, 2020
Rich Chiodo (rchiodo)
approved these changes
Aug 12, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12920
This reverses #12712 and #12789 since the feature has been fully rolled out to 100% of customers.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).