Skip to content

Changed default save name when exporting from interactive window - #12815

Merged
Tim Ruscica (techwithtim) merged 5 commits into
microsoft:masterfrom
techwithtim:defaultname
Jul 8, 2020
Merged

Changed default save name when exporting from interactive window#12815
Tim Ruscica (techwithtim) merged 5 commits into
microsoft:masterfrom
techwithtim:defaultname

Conversation

@techwithtim

Copy link
Copy Markdown

Previously when exporting from the interactive window the default exported file name would be blank. This makes the default exported file name the same as the python file that was used to generate the interactive window.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@techwithtim Tim Ruscica (techwithtim) added the no-changelog No news entry required label Jul 8, 2020
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@techwithtim
Tim Ruscica (techwithtim) merged commit 6bd129a into microsoft:master Jul 8, 2020
@techwithtim
Tim Ruscica (techwithtim) deleted the defaultname branch July 8, 2020 22:11
Don Jayamanne (DonJayamanne) pushed a commit that referenced this pull request Jul 10, 2020
)

* changed default export file name from interactice window

* fixed naming issue

* refactor

* fixed tests

* hopefully fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants