Skip to content

Port fix for transient data in notebooks. - #11168

Merged
Rich Chiodo (rchiodo) merged 2 commits into
release-2020.04from
rchiodo/rel_transient
Apr 15, 2020
Merged

Port fix for transient data in notebooks.#11168
Rich Chiodo (rchiodo) merged 2 commits into
release-2020.04from
rchiodo/rel_transient

Conversation

@rchiodo

Copy link
Copy Markdown

Port PR #11164 to release branch and fixup changelog

Rich Chiodo (rchiodo) and others added 2 commits April 14, 2020 17:20
* Remove unwanted elements from cells when saving.

* Fix a sonar warning

* FIx another sonar warning
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat fix

@codecov-io

Codecov (codecov-io) commented Apr 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #11168 into release-2020.04 will increase coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.04   #11168      +/-   ##
===================================================
+ Coverage            61.39%   61.40%   +0.01%     
===================================================
  Files                  596      596              
  Lines                32786    32808      +22     
  Branches              4642     4644       +2     
===================================================
+ Hits                 20128    20145      +17     
- Misses               11640    11643       +3     
- Partials              1018     1020       +2     
Impacted Files Coverage Δ
...tascience/interactive-ipynb/nativeEditorStorage.ts 48.93% <50.00%> (+0.45%) ⬆️
src/client/datascience/common.ts 100.00% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fa068...d69a3dd. Read the comment docs.

@rchiodo
Rich Chiodo (rchiodo) merged commit 15c68db into release-2020.04 Apr 15, 2020
@rchiodo
Rich Chiodo (rchiodo) deleted the rchiodo/rel_transient branch April 15, 2020 15:46
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants