Complete refactoring of creation and queueing of actions - #10036
Merged
Don Jayamanne (DonJayamanne) merged 3 commits intoFeb 12, 2020
Merged
Conversation
Don Jayamanne (DonJayamanne)
requested review from
David Kutugata (DavidKutu),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
February 10, 2020 23:57
Don Jayamanne (DonJayamanne)
changed the title
Ian Huff (IanMatthewHuff)
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #10036 +/- ##
===================================================
Coverage ? 60.82%
===================================================
Files ? 564
Lines ? 29872
Branches ? 4489
===================================================
Hits ? 18170
Misses ? 10709
Partials ? 993
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some how I had not included some of the other remaining
arg.queueActioninto the originalPR #10019
This PR merely brings them from (I had these in the same branch, but failed to include them).
Same as #10019, just a refactor to use a common function to create an action and dispatch it in one step. & removed some of the old syncing stuff.