Skip to content

Merge for 0.16.1 release#1766

Merged
sean-mcmanus merged 3 commits into
releasefrom
master
Mar 31, 2018
Merged

Merge for 0.16.1 release#1766
sean-mcmanus merged 3 commits into
releasefrom
master

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

Merge for 0.16.1 release

WardenGnaw and others added 3 commits March 28, 2018 15:58
* Adding file validation for download and unzip.

Refactored the download retry code.

Added error handlers for read and write streams.

WriteStream writes to a *.tmp file and then renames. This catches the
case if VSCode dies in the middle of this process and the file is
partially written. We will continue where we left off.

* Adding return to resolve/reject calls.

* Fix retry loop and check err in unlink and rename

* Actually wait for those promises

* Fix TSLint error
@sean-mcmanus sean-mcmanus merged commit 88a0494 into release Mar 31, 2018
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants