Adding file validation for download and unzip.#1751
Merged
WardenGnaw merged 5 commits intoMar 28, 2018
Conversation
Refactored the download retry code. Added error handlers for read and write streams. WriteStream writes to a *.tmp file and then renames. This catches the case if VSCode dies in the middle of this process and the file is partially written. We will continue where we left off.
WardenGnaw
requested review from
bobbrow,
grdowns,
pieandcakes and
sean-mcmanus
sean-mcmanus
approved these changes
Mar 28, 2018
Contributor
|
We found a couple more last minute bugs so we're going to re-start the 0.16.0 release. Is this okay to add to the 0.16.0 release too? Bob was saying he didn't want this change to go into the release branch yet. |
Member
Author
|
@sean-mcmanus Sounds good to me. |
Member
|
you can merge to master, but let's not merge to release for March |
pieandcakes
approved these changes
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the download retry code.
Added error handlers for read and write streams.
WriteStream writes to a *.tmp file and then renames. This catches the
case if VSCode dies in the middle of this process and the file is
partially written. We will continue where we left off.
Hopefully addresses issues like #1661