Don't set the compilerPath if the default is empty.#1741
Merged
Conversation
Contributor
Author
|
I'm still testing this change along with the language server side changes... |
bobbrow
requested changes
Mar 27, 2018
| // Update the compilerPath, cStandard, and cppStandard with the default if they're missing. | ||
| let config: Configuration = this.configurationJson.configurations[this.CurrentConfiguration]; | ||
| if (config.compilerPath === undefined) { | ||
| if (config.compilerPath === undefined && this.defaultCompilerPath && !config.compileCommands) { |
Member
There was a problem hiding this comment.
Why would we turn this off if compileCommands is set? There are cases where we can't get the compiler info from compile_commands.json because the command begins with a custom script or something. I believe we would fall back to the guessed compiler in that case and should propagate the chosen compiler back to c_cpp_properties.json
bobbrow
approved these changes
Mar 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.