Skip to content

Improve documentation#1515

Merged
bobbrow merged 1 commit into
microsoft:masterfrom
faheel:master
Feb 7, 2018
Merged

Improve documentation#1515
bobbrow merged 1 commit into
microsoft:masterfrom
faheel:master

Conversation

@faheel

@faheel faheel commented Feb 2, 2018

Copy link
Copy Markdown
Contributor
  • Improve Markdown formatting
    • Use lists and headings at appropriate places (eg. to list configuration options/properties)
    • Increase heading levels that were too small
    • Remove extra indentation at a few places
  • Use consistent formatting rules for all Markdown files
    • Files and folders are in bold
    • Code and commands are in code spans/blocks and syntax highlighted
  • Fix typos
  • Fix broken links

@bobbrow bobbrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to our documentation!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that a question mark belongs here. No question is being asked.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I'll fix it.

Comment thread Documentation/LanguageServer/FAQ.md Outdated

@bobbrow bobbrow Feb 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link appears to be removed (link #4)

Comment thread README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason why the mailto: link is removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link seems to work without it? Maybe GitHub is smart about it and adds stuff.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was redundant. A mailto link is automatically generated for an email address.

* improve Markdown formatting
* use consistent formatting rules for all Markdown files
* fix typos
* fix broken links

@sean-mcmanus sean-mcmanus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of errors were fixed. And different tagging used. Seems good to me.

@sean-mcmanus

Copy link
Copy Markdown
Contributor

@bobbrow Were you okay with accepting this pull request?

@bobbrow

bobbrow commented Feb 6, 2018

Copy link
Copy Markdown
Member

I'm confused. I didn't see any updates pushed to this PR and there is only one commit listed. When did it get updated?

@bobbrow bobbrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@faheel

faheel commented Feb 7, 2018

Copy link
Copy Markdown
Contributor Author

I squashed the changes suggested in the review into the original PR commit.

@bobbrow bobbrow merged commit e6d8d1f into microsoft:master Feb 7, 2018
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants