tslint: Force semicolon in object literal#1493
Merged
WardenGnaw merged 1 commit intoJan 26, 2018
Merged
Conversation
sean-mcmanus
approved these changes
Jan 26, 2018
bobbrow
approved these changes
Jan 26, 2018
| } | ||
|
|
||
| public showWorkspaces(workspaceNames: { name: string, key: string }[]): Thenable<string> { | ||
| public showWorkspaces(workspaceNames: { name: string; key: string }[]): Thenable<string> { |
Member
There was a problem hiding this comment.
i wonder why it doesn't force it for the second field
Member
Author
There was a problem hiding this comment.
Technically not required, similar to having a trailing comma at the end of the last element of the array.
I'm not sure if there is an existing core rule on this but I can create one.
Member
There was a problem hiding this comment.
nah, don't worry about it. I was just curious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.