fix a bug in resolveVariables util function#1488
Merged
Merged
Conversation
WardenGnaw
approved these changes
Jan 24, 2018
Member
|
Possibility anything that was comparing to null/undefined. |
Contributor
|
This article recommends avoiding using null: https://medium.com/@basarat/null-vs-undefined-in-typescript-land-dc0c7a5f240a . |
sean-mcmanus
approved these changes
Jan 24, 2018
Member
|
I think anywhere where we have === or !== to null or undefined we can just check to see if it is a Truthy or Falsey class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to triple equals had an unintended side effect for this utility function. We should look for other potential regressions, but I need this now to get the language server unblocked.