Skip to content

Add setting to throttle workspace parsing.#1389

Merged
sean-mcmanus merged 15 commits into
masterfrom
users/seanmcm/addThrottleWorkspaceParsing
Jan 9, 2018
Merged

Add setting to throttle workspace parsing.#1389
sean-mcmanus merged 15 commits into
masterfrom
users/seanmcm/addThrottleWorkspaceParsing

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Dec 30, 2017

Copy link
Copy Markdown
Contributor

Add workspaceParsingPriority and exclusionPolicy settings.

@sean-mcmanus sean-mcmanus requested a review from bobbrow December 30, 2017 05:08
@pieandcakes

Copy link
Copy Markdown
Contributor

:shipit:

@bobbrow bobbrow changed the title Add throttleWorkspaceParsing setting. Add setting to throttle workspace parsing. Jan 8, 2018
Comment thread Extension/CHANGELOG.md Outdated
# C/C++ for Visual Studio Code Change Log

## Version 0.14.6: Janurary 2, 2017
## Version 0.14.6: Janurary 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe January 10 is when we're planning to submit this update

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were talking about the 16th per Rong's mail?

Comment thread Extension/CHANGELOG.md
* Fix "Include file not found" messages not re-appearing after settings changes. [#1363](https://github.com/Microsoft/vscode-cpptools/issues/1363)
* Performance improvements when no files need to be parsed, and stop showing "Parsing files" when there's no actual parsing. [#1393](https://github.com/Microsoft/vscode-cpptools/issues/1393)
* Fix crash when settings with the wrong type are used. [#1396](https://github.com/Microsoft/vscode-cpptools/issues/1396)
* Add `C_Cpp.workspaceParsingPriority` setting to avoid using 100% CPU during parsing of workspace files.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Add C_Cpp.workspaceParsingPriority setting to allow users to throttle CPU usage during parsing of workspace files."

Comment thread Extension/CHANGELOG.md
* Performance improvements when no files need to be parsed, and stop showing "Parsing files" when there's no actual parsing. [#1393](https://github.com/Microsoft/vscode-cpptools/issues/1393)
* Fix crash when settings with the wrong type are used. [#1396](https://github.com/Microsoft/vscode-cpptools/issues/1396)
* Add `C_Cpp.workspaceParsingPriority` setting to avoid using 100% CPU during parsing of workspace files.
* Add `C_Cpp.exclusionPolicy` default to `checkFolders` to avoid expensive `files.exclude` checking on every file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Add C_Cpp.exclusionPolicy. Default to checkFolders to avoid expensive files.exclude checking on every file."

Comment thread Extension/package.json Outdated
"checkFilesAndFolders"
],
"default": "checkFolders",
"description": "Instructs the extension when to use the \"files.exclude\" setting when determining which files should be added to the code navigation database while traversing through the paths in the \"browse.path\" array. \"checkFolders\" means that the exclusion filters will only be evaluated once per folder (all children of the folder are excluded). \"checkFilesAndFolders\" means that the exclusion filters will be evaluated against every file and folder encountered. If your \"files.exclude\" setting only contains folders, then \"checkFolders\" is the best choice and will increase the speed at which the extension can initialize the code navigation database.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace "(all children of the folder are excluded)" with "(individual files are not checked)"

@sean-mcmanus sean-mcmanus added this to the January 2018 milestone Jan 9, 2018
@sean-mcmanus sean-mcmanus merged commit 1bfb247 into master Jan 9, 2018
@sean-mcmanus sean-mcmanus deleted the users/seanmcm/addThrottleWorkspaceParsing branch January 9, 2018 01:54
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants