Fix async TestInitialize/TestCleanup causing COMException in WinUI UITestMethod by @Copilot in #8119 (backport to rel/4.2)#8147
Closed
nohwnd-bot wants to merge 9 commits into
Closed
Conversation
…ation Co-authored-by: Evangelink <[email protected]>
The test was using _testMethodInfo which has a 1-hour timeout set, causing IsTimeoutSet to be true. This routes through ExecuteInternalWithTimeoutAsync's non-cooperative path which runs ExecuteInternalAsync on a separate thread pool thread where SynchronizationContext.Current is null. Create a local TestMethodInfo without a timeout so the test goes through the direct ExecuteInternalAsync path on the SC's thread, which is the code path the production fix targets.
…handling, TestCleanup test, and fix comment accuracy Co-authored-by: Evangelink <[email protected]>
…t, use FluentAssertions, suppress CA2007
…dispose, fix null! and AwesomeAssertions
…to cleanup test, bounded Join, fix CS0160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8119 to rel/4.2
/cc @Evangelink @copilot