Fix matplotlib subplots overload return types and reintroduce Test action - #265
Merged
Merged
Conversation
Erik De Bonte (debonte)
requested review from
Bill Schnurr (bschnurr) and
Graham Wheeler (gramster)
April 12, 2023 15:31
Contributor
Author
|
Oh, I thought that the action had to exist in main before PRs would pick it up. I'll add my matplotlib changes to this PR. |
Erik De Bonte (debonte)
changed the title
Bill Schnurr (bschnurr)
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/pylance-release#3482
Also recreating the "Test" action which was retired in #208. Removed the pandas-specific parts. Initially I just want to be able to run Pyright against files that use
assert_typeto validate the return type of complex overloads in matplotlib.