You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When /bin is a symlink to /usr/bin (common on modern Linux distros), find_cached() canonicalizes /bin → /usr/bin and only caches entries under /usr/bin. A subsequent try_from call with /bin/python3 fails the direct cache lookup and returns None, causing the environment to be reported as Unknown.
Fix: In try_from, after a cache miss, canonicalize the executable path and retry the lookup. When found via the canonical path, add the original path as a symlink and update both cache entries for consistency.
Canonicalize executable once, use for both path guard and cache fallback
Path guard accepts executables whose canonical path resolves to a known bin dir
Cache fallback adds the original path as a symlink for complete metadata
Both canonical and original cache entries updated to keep symlink lists consistent
Coverage decreased. Please add tests for new code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
/binis a symlink to/usr/bin(common on modern Linux distros),find_cached()canonicalizes/bin→/usr/binand only caches entries under/usr/bin. A subsequenttry_fromcall with/bin/python3fails the direct cache lookup and returnsNone, causing the environment to be reported asUnknown.Fix: In
try_from, after a cache miss, canonicalize the executable path and retry the lookup. When found via the canonical path, add the original path as a symlink and update both cache entries for consistency.Fixes #405