Add missing Float16Array constructors by greggman · Pull Request #62351 · microsoft/TypeScript

greggman · 2025-08-28T21:50:20Z

These 2 constructor overloads appear to be missing. You can find similar overloads for other typed array constructors in es6.d.ts

Fixes #62343

Copilot

Pull Request Overview

This PR adds missing constructor overloads for the Float16Array type to bring it in line with other typed array constructors. The change ensures type consistency across all typed array types in TypeScript's standard library definitions.

Adds Float16Array constructor overloads to match existing patterns for other typed arrays
Updates test coverage to include Float16Array in typed array constructor validation

greggman · 2025-08-28T21:52:20Z

@microsoft-github-policy-service agree

jakebailey · 2025-09-09T16:49:49Z

This LGTM but needs a format to be accepted.

These 2 constructor overloads appear to be missing. You can find similar overloads for other typed array constructors in `es6.d.ts`

greggman · 2025-09-09T16:52:45Z

ran npm run format. It added a newline. pushed.

jakebailey · 2025-09-09T16:59:31Z

@typescript-bot test it

probably won't say anything interesting, but

typescript-bot · 2025-09-09T16:59:37Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2025-09-09T17:07:50Z

@typescript-bot cherry-pick this to release-5.9

typescript-bot · 2025-09-09T17:07:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.9`	✅ Started	✅ Results

typescript-bot · 2025-09-09T17:10:43Z

Hey, @jakebailey! I've created #62426 for you.

typescript-bot · 2025-09-09T17:24:12Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-09-09T17:26:00Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62351/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-09-09T17:56:11Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,141k (± 0.95%)}	_{193,523k (± 0.77%)}	_~	_192,845k	_196,568k	_{p=0.173 n=6}
_{Parse Time}	_1.31s	_{1.31s (± 0.48%)}	_~	_1.30s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.19%)}	_{9.75s (± 0.33%)}	_~	_9.69s	_9.79s	_{p=0.370 n=6}
_{Emit Time}	_{2.75s (± 0.59%)}	_{2.74s (± 0.85%)}	_~	_2.72s	_2.78s	_{p=0.738 n=6}
_{Total Time}	_{14.54s (± 0.18%)}	_{14.53s (± 0.28%)}	_~	_14.49s	_14.60s	_{p=0.252 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,914	_948,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,884	_410,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,246,603k (± 0.00%)}	_{1,246,638k (± 0.01%)}	_~	_1,246,520k	_1,246,717k	_{p=0.378 n=6}
_{Parse Time}	_{6.51s (± 1.15%)}	_{6.51s (± 0.72%)}	_~	_6.47s	_6.59s	_{p=0.624 n=6}
_{Bind Time}	_{1.87s (± 0.22%)}	_{1.87s (± 0.44%)}	_~	_1.86s	_1.88s	_{p=0.584 n=6}
_{Check Time}	_{32.18s (± 0.41%)}	_{32.21s (± 0.14%)}	_~	_32.13s	_32.27s	_{p=0.936 n=6}
_{Emit Time}	_{14.88s (± 0.37%)}	_{14.86s (± 0.25%)}	_~	_14.81s	_14.91s	_{p=0.688 n=6}
_{Total Time}	_{55.43s (± 0.26%)}	_{55.45s (± 0.10%)}	_~	_55.39s	_55.53s	_{p=0.687 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,542,217	_2,542,217	_~	_~	_~	_{p=1.000 n=6}
_Types	_902,596	_902,596	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,827,795k (± 0.00%)}	_{2,827,763k (± 0.00%)}	_~	_2,827,575k	_2,827,854k	_{p=0.689 n=6}
_{Parse Time}	_{8.74s (± 0.29%)}	_{8.76s (± 0.29%)}	_~	_8.73s	_8.78s	_{p=0.119 n=6}
_{Bind Time}	_{2.18s (± 0.38%)}	_{2.18s (± 0.65%)}	_~	_2.16s	_2.20s	_{p=0.503 n=6}
_{Check Time}	_{86.37s (± 1.24%)}	_{86.28s (± 0.23%)}	_~	_85.93s	_86.46s	_{p=0.297 n=6}
_{Emit Time}	_{0.30s (± 1.35%)}	_{0.62s (±125.19%)}	_~	_0.30s	_2.20s	_{p=0.527 n=6}
_{Total Time}	_{97.60s (± 1.07%)}	_{97.84s (± 0.63%)}	_~	_97.43s	_99.07s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,236,922	_1,236,958	_{+36 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,638	_259,638	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,386,981k (± 0.02%)}	_{2,447,614k (± 6.05%)}	_~	_2,386,810k	_2,750,219k	_{p=0.230 n=6}
_{Parse Time}	_{5.19s (± 0.32%)}	_{5.18s (± 1.00%)}	_~	_5.10s	_5.25s	_{p=0.810 n=6}
_{Bind Time}	_{1.82s (± 0.67%)}	_{1.80s (± 0.78%)}	_~	_1.78s	_1.82s	_{p=0.087 n=6}
_{Check Time}	_{35.15s (± 0.30%)}	_{35.03s (± 0.52%)}	_~	_34.67s	_35.18s	_{p=0.230 n=6}
_{Emit Time}	_{2.98s (± 1.91%)}	_{2.99s (± 1.31%)}	_~	_2.95s	_3.05s	_{p=0.810 n=6}
_{Total Time}	_{45.15s (± 0.26%)}	_{45.01s (± 0.42%)}	_~	_44.67s	_45.17s	_{p=0.230 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,236,922	_1,236,958	_{+36 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,638	_259,638	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,939,515k (±12.70%)}	_{2,966,146k (±11.33%)}	_~	_2,457,418k	_3,181,622k	_{p=0.689 n=6}
_{Parse Time}	_{6.92s (± 2.53%)}	_{6.84s (± 1.17%)}	_~	_6.71s	_6.93s	_{p=0.296 n=6}
_{Bind Time}	_{2.20s (± 1.76%)}	_{2.18s (± 1.87%)}	_~	_2.14s	_2.23s	_{p=0.422 n=6}
_{Check Time}	_{42.41s (± 0.47%)}	_{42.31s (± 0.76%)}	_~	_41.74s	_42.56s	_{p=0.810 n=6}
_{Emit Time}	_{3.52s (± 2.57%)}	_{3.50s (± 1.52%)}	_~	_3.44s	_3.57s	_{p=0.748 n=6}
_{Total Time}	_{55.07s (± 0.72%)}	_{54.84s (± 0.70%)}	_~	_54.21s	_55.11s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,416	_262,420	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_103,917	_103,917	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,697k (± 0.02%)}	_{441,677k (± 0.01%)}	_~	_441,603k	_441,764k	_{p=0.810 n=6}
_{Parse Time}	_{4.42s (± 1.12%)}	_{4.41s (± 0.60%)}	_~	_4.37s	_4.44s	_{p=0.936 n=6}
_{Bind Time}	_{1.63s (± 1.45%)}	_{1.63s (± 1.23%)}	_~	_1.60s	_1.66s	_{p=1.000 n=6}
_{Check Time}	_{23.45s (± 0.71%)}	_{23.55s (± 0.36%)}	_~	_23.44s	_23.65s	_{p=0.336 n=6}
_{Emit Time}	_{1.91s (± 1.38%)}	_{1.91s (± 0.90%)}	_~	_1.88s	_1.93s	_{p=1.000 n=6}
_{Total Time}	_{31.40s (± 0.65%)}	_{31.50s (± 0.22%)}	_~	_31.42s	_31.59s	_{p=0.521 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,188k (± 0.03%)}	_{371,146k (± 0.02%)}	_~	_371,071k	_371,224k	_{p=0.810 n=6}
_{Parse Time}	_{3.59s (± 0.63%)}	_{3.59s (± 1.16%)}	_~	_3.55s	_3.65s	_{p=0.809 n=6}
_{Bind Time}	_{1.97s (± 0.81%)}	_{1.96s (± 1.24%)}	_~	_1.94s	_2.00s	_{p=0.220 n=6}
_{Check Time}	_{20.33s (± 0.39%)}	_{20.40s (± 0.35%)}	_~	_20.26s	_20.46s	_{p=0.294 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.89s (± 0.36%)}	_{25.95s (± 0.25%)}	_~	_25.84s	_26.01s	_{p=0.296 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,888,179	_3,888,179	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,225,176	_1,225,176	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,712,684k (± 0.01%)}	_{3,712,316k (± 0.00%)}	_{-368k (- 0.01%)}	_3,712,157k	_3,712,581k	_{p=0.031 n=6}
_{Parse Time}	_{18.90s (± 0.27%)}	_{18.96s (± 0.78%)}	_~	_18.79s	_19.14s	_{p=0.688 n=6}
_{Bind Time}	_{6.08s (± 2.25%)}	_{6.04s (± 0.88%)}	_~	_5.97s	_6.11s	_{p=0.936 n=6}
_{Check Time}	_{127.92s (± 2.87%)}	_{123.86s (± 1.47%)}	_{🟩-4.06s (- 3.17%)}	_122.57s	_126.55s	_{p=0.020 n=6}
_{Emit Time}	_{39.73s (± 9.17%)}	_{46.33s (± 8.82%)}	_{🔻+6.60s (+16.61%)}	_43.05s	_54.38s	_{p=0.045 n=6}
_{Total Time}	_{192.64s (± 1.74%)}	_{195.20s (± 2.25%)}	_~	_190.93s	_202.38s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_361,368	_361,372	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_158,854	_158,854	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{519,048k (± 0.04%)}	_{519,190k (± 0.03%)}	_~	_518,951k	_519,358k	_{p=0.378 n=6}
_{Parse Time}	_{4.59s (± 0.62%)}	_{4.63s (± 0.50%)}	_{+0.04s (+ 0.84%)}	_4.59s	_4.65s	_{p=0.041 n=6}
_{Bind Time}	_{1.91s (± 1.74%)}	_{1.95s (± 1.24%)}	_~	_1.90s	_1.97s	_{p=0.106 n=6}
_{Check Time}	_{22.01s (± 0.50%)}	_{22.08s (± 1.00%)}	_~	_21.86s	_22.47s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{28.51s (± 0.37%)}	_{28.66s (± 0.81%)}	_~	_28.41s	_29.06s	_{p=0.296 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_668,461	_668,465	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_200,558	_200,558	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{573,965k (± 0.01%)}	_{573,887k (± 0.02%)}	_~	_573,669k	_574,004k	_{p=0.575 n=6}
_{Parse Time}	_{4.27s (± 0.32%)}	_{4.28s (± 0.71%)}	_~	_4.24s	_4.32s	_{p=0.739 n=6}
_{Bind Time}	_{1.32s (± 0.88%)}	_{1.34s (± 0.47%)}	_{+0.02s (+ 1.39%)}	_1.33s	_1.35s	_{p=0.019 n=6}
_{Check Time}	_{20.09s (± 0.41%)}	_{20.34s (± 1.99%)}	_~	_19.93s	_20.85s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.69s (± 0.34%)}	_{25.96s (± 1.53%)}	_~	_25.53s	_26.48s	_{p=0.173 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-09-09T18:20:56Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62351/merge:

Everything looks good!

…e-5.9 (#62426) Co-authored-by: Greggman <[email protected]>

Copilot AI review requested due to automatic review settings August 28, 2025 21:50

github-project-automation bot added this to PR Backlog Aug 28, 2025

github-project-automation bot moved this to Not started in PR Backlog Aug 28, 2025

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 28, 2025

Copilot AI reviewed Aug 28, 2025

View reviewed changes

jakebailey approved these changes Sep 9, 2025

View reviewed changes

github-project-automation bot moved this from Not started to Needs merge in PR Backlog Sep 9, 2025

Add missing Float16Array constructors

97664b0

These 2 constructor overloads appear to be missing. You can find similar overloads for other typed array constructors in `es6.d.ts`

jakebailey approved these changes Sep 9, 2025

View reviewed changes

typescript-bot mentioned this pull request Sep 9, 2025

🤖 Pick PR #62351 (Add missing Float16Array constructo...) into release-5.9 #62426

Merged

jakebailey merged commit 3320dfd into microsoft:main Sep 9, 2025
33 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Sep 9, 2025

jakebailey pushed a commit that referenced this pull request Sep 25, 2025

🤖 Pick PR #62351 (Add missing Float16Array constructo...) into releas…

a131cac

…e-5.9 (#62426) Co-authored-by: Greggman <[email protected]>

claude bot mentioned this pull request Oct 7, 2025

chore(deps-dev): bump typescript from 5.9.2 to 5.9.3 DollhouseMCP/mcp-server#1247

Merged

Conversation

greggman commented Aug 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

greggman commented Aug 28, 2025

Uh oh!

jakebailey commented Sep 9, 2025

Uh oh!

greggman commented Sep 9, 2025

Uh oh!

jakebailey commented Sep 9, 2025

Uh oh!

typescript-bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Sep 9, 2025

Uh oh!

typescript-bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 9, 2025

Uh oh!

typescript-bot commented Sep 9, 2025

Uh oh!

typescript-bot commented Sep 9, 2025

Uh oh!

typescript-bot commented Sep 9, 2025

tsc

Uh oh!

typescript-bot commented Sep 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Sep 9, 2025 •

edited

Loading

typescript-bot commented Sep 9, 2025 •

edited

Loading